RESOLVED FIXED 198250
[LFC][Verification] Add areEssentiallyEqual for LayoutRect 
https://bugs.webkit.org/show_bug.cgi?id=198250
Summary [LFC][Verification] Add areEssentiallyEqual for LayoutRect
alan baradlay
Reported 2019-05-25 18:02:18 PDT
WebKit's inline layout is a mix of int/float/LayoutUnit while LFC mostly uses LayoutUnit. The used size of a block container (based on the inline tree) could go through a few conversions.
Attachments
Patch (3.96 KB, patch)
2019-05-25 18:59 PDT, alan baradlay 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews114 for mac-highsierra (2.97 MB, application/zip)
2019-05-25 20:51 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-05-25 18:03:00 PDT
<rdar://problem/51140119>
alan baradlay
Comment 2 2019-05-25 18:59:06 PDT
Created attachment 370640 [details] Patch
EWS Watchlist
Comment 3 2019-05-25 20:51:39 PDT
Comment on attachment 370640 [details] Patch Attachment 370640 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12291085 New failing tests: webaudio/silent-audio-interrupted-in-background.html
EWS Watchlist
Comment 4 2019-05-25 20:51:40 PDT
Created attachment 370643 [details] Archive of layout-test-results from ews114 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-highsierra Platform: Mac OS X 10.13.6
alan baradlay
Comment 5 2019-05-25 20:52:29 PDT
(In reply to Build Bot from comment #3) > Comment on attachment 370640 [details] > Patch > > Attachment 370640 [details] did not pass mac-debug-ews (mac): > Output: https://webkit-queues.webkit.org/results/12291085 > > New failing tests: > webaudio/silent-audio-interrupted-in-background.html Nope
WebKit Commit Bot
Comment 6 2019-05-26 07:04:20 PDT
Comment on attachment 370640 [details] Patch Clearing flags on attachment: 370640 Committed r245779: <https://trac.webkit.org/changeset/245779>
WebKit Commit Bot
Comment 7 2019-05-26 07:04:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.