Bug 198250 - [LFC][Verification] Add areEssentiallyEqual for LayoutRect
Summary: [LFC][Verification] Add areEssentiallyEqual for LayoutRect
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-25 18:02 PDT by zalan
Modified: 2019-05-26 07:04 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.96 KB, patch)
2019-05-25 18:59 PDT, zalan 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews114 for mac-highsierra (2.97 MB, application/zip)
2019-05-25 20:51 PDT, Build Bot 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-05-25 18:02:18 PDT 
WebKit's inline layout is a mix of int/float/LayoutUnit while LFC mostly uses LayoutUnit. The used size of a block container (based on the inline tree) could go through a few conversions.
Comment 1 Radar WebKit Bug Importer 2019-05-25 18:03:00 PDT 
<rdar://problem/51140119>
Comment 2 zalan 2019-05-25 18:59:06 PDT 
Created attachment 370640 [details]
Patch
Comment 3 Build Bot 2019-05-25 20:51:39 PDT 
Comment on attachment 370640 [details]
Patch

Attachment 370640 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12291085

New failing tests:
webaudio/silent-audio-interrupted-in-background.html
Comment 4 Build Bot 2019-05-25 20:51:40 PDT 
Created attachment 370643 [details]
Archive of layout-test-results from ews114 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 5 zalan 2019-05-25 20:52:29 PDT 
(In reply to Build Bot from comment #3)
> Comment on attachment 370640 [details]
> Patch
> 
> Attachment 370640 [details] did not pass mac-debug-ews (mac):
> Output: https://webkit-queues.webkit.org/results/12291085
> 
> New failing tests:
> webaudio/silent-audio-interrupted-in-background.html
Nope
Comment 6 WebKit Commit Bot 2019-05-26 07:04:20 PDT 
Comment on attachment 370640 [details]
Patch

Clearing flags on attachment: 370640

Committed r245779: <https://trac.webkit.org/changeset/245779>
Comment 7 WebKit Commit Bot 2019-05-26 07:04:21 PDT 
All reviewed patches have been landed.  Closing bug.