Bug 198236 - Update sandbox rules for more News use cases
Summary: Update sandbox rules for more News use cases
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-24 15:30 PDT by Brent Fulgham
Modified: 2019-05-28 10:34 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.15 KB, patch)
2019-05-24 15:33 PDT, Brent Fulgham 		ap: review+
ap: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2019-05-24 15:30:20 PDT 
Update the WebContent and Network process sandboxes so that News has the same set of allowed service access as regular WebKit views.
Comment 1 Brent Fulgham 2019-05-24 15:30:53 PDT 
<rdar://problem/50054027>
Comment 2 Brent Fulgham 2019-05-24 15:33:27 PDT 
Created attachment 370597 [details]
Patch
Comment 3 Alexey Proskuryakov 2019-05-24 16:58:38 PDT 
Comment on attachment 370597 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370597&action=review

> Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:46
> +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300 || PLATFORM(IOSMAC)

Please remove most of these #ifs. 10.13 is the minimum.
Comment 4 Brent Fulgham 2019-05-28 10:32:54 PDT 
(In reply to Alexey Proskuryakov from comment #3)
> Comment on attachment 370597 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=370597&action=review
> 
> > Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:46
> > +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300 || PLATFORM(IOSMAC)
> 
> Please remove most of these #ifs. 10.13 is the minimum.

I don't think that's true until we ship in the fall? 10.14 is current shipping, and we support current and two back.
Comment 5 Brent Fulgham 2019-05-28 10:34:05 PDT 
Committed r245817: <https://trac.webkit.org/changeset/245817>