Bug 198235 - [WHLSL] Allow vertex attributes to have arbitrary names in the shader
Summary: [WHLSL] Allow vertex attributes to have arbitrary names in the shader
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Fan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-24 15:27 PDT by Myles C. Maxfield
Modified: 2019-05-24 16:39 PDT (History)
5 users (show)

See Also:

Attachments
WIP (4.61 KB, patch)
2019-05-24 15:27 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (12.97 KB, patch)
2019-05-24 15:47 PDT, Myles C. Maxfield 		dino: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2019-05-24 15:27:01 PDT 
[WHLSL] Allow vertex attributes to have arbitrary names in the shader
Comment 1 Myles C. Maxfield 2019-05-24 15:27:18 PDT 
Created attachment 370595 [details]
WIP
Comment 2 EWS Watchlist 2019-05-24 15:29:12 PDT 
Attachment 370595 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Myles C. Maxfield 2019-05-24 15:47:59 PDT 
Created attachment 370599 [details]
Patch
Comment 4 Justin Fan 2019-05-24 16:14:45 PDT 
Looks good to me!
Comment 5 Myles C. Maxfield 2019-05-24 16:38:26 PDT 
Committed r245759: <https://trac.webkit.org/changeset/245759>
Comment 6 Radar WebKit Bug Importer 2019-05-24 16:39:22 PDT 
<rdar://problem/51126717>