Bug 198218 - [ews-build] Do not display unnecessary steps in the Buildbot build page UI
Summary: [ews-build] Do not display unnecessary steps in the Buildbot build page UI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-24 05:33 PDT by Aakash Jain
Modified: 2019-06-04 14:27 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.20 KB, patch)
2019-05-24 05:36 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews211 for win-future (13.59 MB, application/zip)
2019-05-24 09:21 PDT, EWS Watchlist
no flags Details
Patch (1.69 KB, patch)
2019-06-04 12:20 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff
Patch (2.01 KB, patch)
2019-06-04 14:12 PDT, Aakash Jain
jbedard: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-05-24 05:33:25 PDT
To make the buildbot build page more readable for regular users, we should hide certain steps (especially when they are successful).
Comment 1 Radar WebKit Bug Importer 2019-05-24 05:33:37 PDT
<rdar://problem/51104544>
Comment 2 Aakash Jain 2019-05-24 05:36:40 PDT
Created attachment 370570 [details]
Patch
Comment 3 EWS Watchlist 2019-05-24 09:21:21 PDT Comment hidden (obsolete)
Comment 4 EWS Watchlist 2019-05-24 09:21:24 PDT Comment hidden (obsolete)
Comment 5 Jonathan Bedard 2019-05-28 08:42:04 PDT
I'd like to see this active on the UAT environment first.

I can see the arguments for it, but there are also some pretty compelling ones against doing something like this. It may hide warnings which were classified as successes but eventually caused a later failure. Something that comes to mind (and has historically been a problem on trunk infrastructure) would be issues with stale SVN files.
Comment 6 Aakash Jain 2019-06-04 12:20:14 PDT
Created attachment 371315 [details]
Patch
Comment 7 Aakash Jain 2019-06-04 14:12:21 PDT
Created attachment 371329 [details]
Patch
Comment 8 Aakash Jain 2019-06-04 14:27:10 PDT
Committed r246080: <https://trac.webkit.org/changeset/246080>