Bug 198207 - Web Inspector: prevent stripping `console.assert` if it's used inside a string
Summary: Web Inspector: prevent stripping `console.assert` if it's used inside a string
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks: 195132
  Show dependency tree / graph
 
Reported: 2019-05-23 19:15 PDT by Devin Rousso
Modified: 2019-05-23 20:20 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.86 KB, patch)
2019-05-23 19:24 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (2.85 KB, patch)
2019-05-23 19:26 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (2.86 KB, patch)
2019-05-23 19:30 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (1.87 KB, patch)
2019-05-23 19:39 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-05-23 19:15:32 PDT 
```
    console.assert(false, "foo");
```
should be stripped


```
    let x = "console.assert(false);"
```
should not be stripped
Comment 1 Devin Rousso 2019-05-23 19:24:33 PDT 
Created attachment 370546 [details]
Patch
Comment 2 Devin Rousso 2019-05-23 19:26:16 PDT 
Created attachment 370547 [details]
Patch
Comment 3 Joseph Pecoraro 2019-05-23 19:28:52 PDT 
Comment on attachment 370547 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370547&action=review

> Source/WebInspectorUI/Scripts/remove-console-asserts.pl:52
> +        s/^\s*console\.assert\(.*\);\s*//g;

This is nice. I approve this.

> Source/WebInspectorUI/Scripts/remove-console-asserts.pl:59
> +            next if /^["'`]*console\.assert/;

This doesn't do what you think it does.
Comment 4 Devin Rousso 2019-05-23 19:30:49 PDT 
Created attachment 370548 [details]
Patch
Comment 5 Joseph Pecoraro 2019-05-23 19:33:57 PDT 
Comment on attachment 370548 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370548&action=review

sh

> Source/WebInspectorUI/Scripts/remove-console-asserts.pl:59
> +            next if /^.*?["'`].*?console\.assert/;

/["'`].*?console\.assert/
Comment 6 Joseph Pecoraro 2019-05-23 19:35:11 PDT 
Comment on attachment 370548 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370548&action=review

>> Source/WebInspectorUI/Scripts/remove-console-asserts.pl:59
>> +            next if /^.*?["'`].*?console\.assert/;
> 
> /["'`].*?console\.assert/

/\/\/.*?console\.assert/
Comment 7 Devin Rousso 2019-05-23 19:39:33 PDT 
Created attachment 370553 [details]
Patch
Comment 8 WebKit Commit Bot 2019-05-23 20:19:58 PDT 
Comment on attachment 370553 [details]
Patch

Clearing flags on attachment: 370553

Committed r245741: <https://trac.webkit.org/changeset/245741>
Comment 9 WebKit Commit Bot 2019-05-23 20:20:00 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2019-05-23 20:20:25 PDT 
<rdar://problem/51093853>