Bug 198202 - [iOS] WebPage::positionInformation() may set InteractionInformationAtPosition.isImage to true but leave image unset
Summary: [iOS] WebPage::positionInformation() may set InteractionInformationAtPosition...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-23 18:15 PDT by Said Abou-Hallawa
Modified: 2019-05-29 15:07 PDT (History)
6 users (show)

See Also:

Attachments
Patch (23.98 KB, patch)
2019-05-23 18:18 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.54 MB, application/zip)
2019-05-23 19:59 PDT, EWS Watchlist 		no flags Details
Patch (26.42 KB, patch)
2019-05-24 17:06 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (26.37 KB, patch)
2019-05-25 11:21 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2019-05-23 18:15:44 PDT 
One case for this to happen is the image dimension = { 1, 1 }.
Comment 1 Said Abou-Hallawa 2019-05-23 18:18:59 PDT 
Created attachment 370537 [details]
Patch
Comment 2 Said Abou-Hallawa 2019-05-23 18:20:35 PDT 
<rdar://problem/50711206>
Comment 3 EWS Watchlist 2019-05-23 19:59:46 PDT 
Comment on attachment 370537 [details]
Patch

Attachment 370537 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12274410

New failing tests:
editing/selection/character-granularity-rect.html
Comment 4 EWS Watchlist 2019-05-23 19:59:47 PDT 
Created attachment 370555 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.5
Comment 5 Tim Horton 2019-05-23 21:23:39 PDT 
Comment on attachment 370537 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370537&action=review

> Source/WebKit/ChangeLog:18
> +        Since WebPage::positionInformation() is a little bit difficult to read

Hah! I’ve been meaning to do this for years, glad someone finally did.
Comment 6 Said Abou-Hallawa 2019-05-24 17:06:34 PDT 
Created attachment 370608 [details]
Patch
Comment 7 Said Abou-Hallawa 2019-05-25 11:21:47 PDT 
Created attachment 370637 [details]
Patch
Comment 8 Tim Horton 2019-05-29 13:25:49 PDT 
Comment on attachment 370637 [details]
Patch

This is mostly a rubber-stamp since it's hard to read around the moved code.
Comment 9 WebKit Commit Bot 2019-05-29 15:07:40 PDT 
Comment on attachment 370637 [details]
Patch

Clearing flags on attachment: 370637

Committed r245872: <https://trac.webkit.org/changeset/245872>
Comment 10 WebKit Commit Bot 2019-05-29 15:07:42 PDT 
All reviewed patches have been landed.  Closing bug.