Bug 198199 - [WHLSL] Make the AST dumper disambiguate expressions using parenthesis to represent AST construction
Summary: [WHLSL] Make the AST dumper disambiguate expressions using parenthesis to rep...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-23 15:49 PDT by Saam Barati
Modified: 2019-05-23 16:43 PDT (History)
7 users (show)

See Also:


Attachments
patch (1.74 KB, patch)
2019-05-23 16:00 PDT, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2019-05-23 15:49:45 PDT
We would dump "*foo.bar" for "(*foo).bar" which is throughly confusing enough to go maximal parens
Comment 1 Saam Barati 2019-05-23 16:00:13 PDT
Created attachment 370530 [details]
patch
Comment 2 Robin Morisset 2019-05-23 16:02:02 PDT
LGTM
Comment 3 WebKit Commit Bot 2019-05-23 16:42:02 PDT
Comment on attachment 370530 [details]
patch

Clearing flags on attachment: 370530

Committed r245727: <https://trac.webkit.org/changeset/245727>
Comment 4 WebKit Commit Bot 2019-05-23 16:42:04 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-05-23 16:43:32 PDT
<rdar://problem/51088170>