Bug 198196 - [WHLSL] Don't wrap anonymous variables in parens in the AST dumper
Summary: [WHLSL] Don't wrap anonymous variables in parens in the AST dumper
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-23 14:49 PDT by Saam Barati
Modified: 2019-05-23 16:14 PDT (History)
7 users (show)

See Also:

Attachments
patch (1.79 KB, patch)
2019-05-23 15:00 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2019-05-23 14:49:11 PDT 
Makes things easier to read IMO
Comment 1 Saam Barati 2019-05-23 14:52:47 PDT 
foo.bar.x = 42;

Goes from
($(0x7f86d9d94440) = &foo, $(0x7f86d9d944e0) = operator.bar(*$(0x7f86d9d94440)), $(0x7f86d9d944e0) = operator.x=($(0x7f86d9d944e0), 42), *$(0x7f86d9d94440) = operator.bar=(*$(0x7f86d9d94440), $(0x7f86d9d944e0)));
to:
($0x7f86d9d94440 = &foo, $0x7f86d9d944e0 = operator.bar(*$0x7f86d9d94440), $0x7f86d9d944e0 = operator.x=($0x7f86d9d944e0, 42), *$0x7f86d9d94440 = operator.bar=(*$0x7f86d9d94440, $0x7f86d9d944e0));
Comment 2 Saam Barati 2019-05-23 15:00:54 PDT 
Created attachment 370523 [details]
patch
Comment 3 WebKit Commit Bot 2019-05-23 16:13:51 PDT 
Comment on attachment 370523 [details]
patch

Clearing flags on attachment: 370523

Committed r245724: <https://trac.webkit.org/changeset/245724>
Comment 4 WebKit Commit Bot 2019-05-23 16:13:52 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-05-23 16:14:20 PDT 
<rdar://problem/51086976>