Bug 198193 - [WHLSL] Property resolver needs to recurse to handle the base when simplifying rvalues
Summary: [WHLSL] Property resolver needs to recurse to handle the base when simplifyin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-23 13:02 PDT by Saam Barati
Modified: 2019-05-23 15:22 PDT (History)
7 users (show)

See Also:


Attachments
patch (9.00 KB, patch)
2019-05-23 13:28 PDT, Saam Barati
mmaxfield: review+
Details | Formatted Diff | Diff
patch for landing (9.65 KB, patch)
2019-05-23 14:38 PDT, Saam Barati
no flags Details | Formatted Diff | Diff
patch for landing (8.98 KB, patch)
2019-05-23 14:40 PDT, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2019-05-23 13:02:43 PDT
...
Comment 1 Saam Barati 2019-05-23 13:28:53 PDT
Created attachment 370518 [details]
patch
Comment 2 Myles C. Maxfield 2019-05-23 14:14:21 PDT
Comment on attachment 370518 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370518&action=review

Cool.

> LayoutTests/webgpu/whlsl-nested-dot-expression-rvalue.html:11
> +    float shade : attribute(0);

I think you should remove the " : attribute(0)"
Comment 3 Saam Barati 2019-05-23 14:38:52 PDT
Created attachment 370520 [details]
patch for landing
Comment 4 Saam Barati 2019-05-23 14:40:11 PDT
Created attachment 370521 [details]
patch for landing
Comment 5 WebKit Commit Bot 2019-05-23 15:21:10 PDT
Comment on attachment 370521 [details]
patch for landing

Clearing flags on attachment: 370521

Committed r245721: <https://trac.webkit.org/changeset/245721>
Comment 6 WebKit Commit Bot 2019-05-23 15:21:12 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-05-23 15:22:22 PDT
<rdar://problem/51084810>