Bug 19819 – WebKit history API crashing.

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebKitGTK

[Xan Lopez]

Just found it, but it seems to not be working at all. At the very least we should commit this:

diff --git a/WebKit/gtk/webkit/webkitwebhistoryitem.cpp b/WebKit/gtk/webkit/webkitwebhistoryitem.cpp
index f1734d3..b98f467 100644
--- a/WebKit/gtk/webkit/webkitwebhistoryitem.cpp
+++ b/WebKit/gtk/webkit/webkitwebhistoryitem.cpp
@@ -363,6 +363,7 @@ const gchar* webkit_web_history_item_get_alternate_title(WebKitWebHistoryItem* w
 void webkit_web_history_item_set_alternate_title(WebKitWebHistoryItem* webHistoryItem, const gchar* ti
 {
     g_return_if_fail(WEBKIT_IS_WEB_HISTORY_ITEM(webHistoryItem));
+    g_return_if_fail(title != NULL);

     WebCore::HistoryItem* item = core(webHistoryItem);


to avoid the crasher (and also a good thing to have in general).

[Martin Robinson]

WebKit1 is long gone.