Bug 19819 - WebKit history API crashing.
Summary: WebKit history API crashing.
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-29 13:23 PDT by Xan Lopez
Modified: 2015-05-07 16:33 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xan Lopez 2008-06-29 13:23:52 PDT 
Just found it, but it seems to not be working at all. At the very least we should commit this:

diff --git a/WebKit/gtk/webkit/webkitwebhistoryitem.cpp b/WebKit/gtk/webkit/webkitwebhistoryitem.cpp
index f1734d3..b98f467 100644
--- a/WebKit/gtk/webkit/webkitwebhistoryitem.cpp
+++ b/WebKit/gtk/webkit/webkitwebhistoryitem.cpp
@@ -363,6 +363,7 @@ const gchar* webkit_web_history_item_get_alternate_title(WebKitWebHistoryItem* w
 void webkit_web_history_item_set_alternate_title(WebKitWebHistoryItem* webHistoryItem, const gchar* ti
 {
     g_return_if_fail(WEBKIT_IS_WEB_HISTORY_ITEM(webHistoryItem));
+    g_return_if_fail(title != NULL);

     WebCore::HistoryItem* item = core(webHistoryItem);


to avoid the crasher (and also a good thing to have in general).
Comment 1 Martin Robinson 2015-05-07 16:33:22 PDT 
WebKit1 is long gone.