Bug 198189 - DFG::OSREntry should not perform arity check
Summary: DFG::OSREntry should not perform arity check
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tadeu Zagallo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-23 11:27 PDT by Tadeu Zagallo
Modified: 2019-05-23 13:44 PDT (History)
7 users (show)

See Also:


Attachments
Patch (2.78 KB, patch)
2019-05-23 11:36 PDT, Tadeu Zagallo
no flags Details | Formatted Diff | Diff
Patch (2.79 KB, patch)
2019-05-23 11:43 PDT, Tadeu Zagallo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tadeu Zagallo 2019-05-23 11:27:57 PDT
The following code compiles 7 times, but never tiers up to DFG because of the arity check:

function foo(x, y) {
    for (var i = 0; i < 1e8; i++) {
        x[y] += i;
    }
}
foo({})
Comment 1 Tadeu Zagallo 2019-05-23 11:36:10 PDT
Created attachment 370511 [details]
Patch
Comment 2 Tadeu Zagallo 2019-05-23 11:43:20 PDT
Created attachment 370513 [details]
Patch

Fix typo in ChangeLog
Comment 3 WebKit Commit Bot 2019-05-23 13:43:55 PDT
Comment on attachment 370513 [details]
Patch

Clearing flags on attachment: 370513

Committed r245710: <https://trac.webkit.org/changeset/245710>
Comment 4 WebKit Commit Bot 2019-05-23 13:43:57 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-05-23 13:44:22 PDT
<rdar://problem/51080799>