Bug 198180 – Fix a few missing header inclusions often masked by by unified sources

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Adrian Perez]

The following are build errors caused by missing includes which
would have been caught much earlier if unified sources weren't used:

../Source/JavaScriptCore/wasm/WasmBinding.cpp:48:22: error: use of undeclared identifier 'wasmCallingConventionAir'
    GPRReg scratch = wasmCallingConventionAir().prologueScratch(0);
                     ^

../Source/JavaScriptCore/assembler/PerfLog.cpp:147:32: error: implicit instantiation of undefined template 'std::__1::array<char, 1024>'
        std::array<char, 1024> filename;
                               ^

../Source/WebCore/html/FeaturePolicy.cpp:53:58: error: use of undeclared identifier 'isHTMLSpace'
    item = item.stripLeadingAndTrailingMatchedCharacters(isHTMLSpace<UChar>);
                                                         ^

../Source/WebCore/platform/text/TextCodec.cpp:43:16: error: use of undeclared identifier 'snprintf'; did you mean 'vswprintf'?
        return snprintf(replacement.data(), sizeof(UnencodableReplacementArray), "&#%u;", codePoint);
               ^~~~~~~~
               vswprintf

[Adrian Perez]

Created attachment 370505 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 370505 [details]
Patch

Clearing flags on attachment: 370505

Committed r245681: <https://trac.webkit.org/changeset/245681>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/51069221>

[Khem Raj]

*** Bug 197085 has been marked as a duplicate of this bug. ***