Bug 198177 - [Pointer Events] The mouseover, mouseout, mouseenter, and mouseleave events should not be prevented while the pointer is down
Summary: [Pointer Events] The mouseover, mouseout, mouseenter, and mouseleave events s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-23 05:04 PDT by Antoine Quint
Modified: 2019-05-23 11:38 PDT (History)
12 users (show)

See Also:


Attachments
Patch (6.90 KB, patch)
2019-05-23 05:09 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-highsierra (3.08 MB, application/zip)
2019-05-23 06:12 PDT, Build Bot
no flags Details
Patch (7.70 KB, patch)
2019-05-23 06:25 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2019-05-23 05:04:33 PDT
[Pointer Events] The mouseover, mouseout, mouseenter, and mouseleave events should not be prevented while the pointer is down
Comment 1 Antoine Quint 2019-05-23 05:09:08 PDT
Created attachment 370500 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-05-23 05:29:34 PDT
<rdar://problem/51064805>
Comment 3 Build Bot 2019-05-23 06:12:55 PDT
Comment on attachment 370500 [details]
Patch

Attachment 370500 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/12268566

New failing tests:
pointerevents/mouse/compatibility-mouse-events-prevention-mouse-pressed.html
Comment 4 Build Bot 2019-05-23 06:12:57 PDT
Created attachment 370503 [details]
Archive of layout-test-results from ews103 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 5 Antoine Quint 2019-05-23 06:25:25 PDT
Created attachment 370504 [details]
Patch
Comment 6 Alexey Proskuryakov 2019-05-23 10:57:16 PDT
Comment on attachment 370504 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370504&action=review

> LayoutTests/ChangeLog:11
> +        * platform/mac-wk1/TestExpectations: Skipping the test on WK1 where the sequence of dispatched mouse events does not match.

Is this something that needs to be fixed at some point in the future?
Comment 7 WebKit Commit Bot 2019-05-23 11:02:20 PDT
Comment on attachment 370504 [details]
Patch

Clearing flags on attachment: 370504

Committed r245695: <https://trac.webkit.org/changeset/245695>
Comment 8 WebKit Commit Bot 2019-05-23 11:02:21 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Simon Fraser (smfr) 2019-05-23 11:32:54 PDT
This broke the macOS build (Element.cpp:291:13: error: unused function 'isCompatibilityMouseEvent' [-Werror,-Wunused-function]).

Fixed in r245700
Comment 10 Antoine Quint 2019-05-23 11:38:14 PDT
(In reply to Alexey Proskuryakov from comment #6)
> Comment on attachment 370504 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=370504&action=review
> 
> > LayoutTests/ChangeLog:11
> > +        * platform/mac-wk1/TestExpectations: Skipping the test on WK1 where the sequence of dispatched mouse events does not match.
> 
> Is this something that needs to be fixed at some point in the future?

I'm not sure how important it is to address, but it's worth tracking. Raised https://bugs.webkit.org/show_bug.cgi?id=198190.