Bug 198165 - Web Inspector: Overlay: rulers should switch sides if they intersect the highlighted node(s) so they don't obstruct any content
Summary: Web Inspector: Overlay: rulers should switch sides if they intersect the high...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-22 22:32 PDT by Devin Rousso
Modified: 2019-05-23 17:11 PDT (History)
7 users (show)

See Also:

Attachments
Patch (17.26 KB, patch)
2019-05-23 01:20 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-05-22 22:32:39 PDT 
If the node being highlighted is against the top edge of the screen, the top ruler should shift to the bottom.

If the node being highlighted is against the left edge of the screen, the left ruler should shift to the right.
Comment 1 Devin Rousso 2019-05-23 01:20:33 PDT 
Created attachment 370495 [details]
Patch
Comment 2 Devin Rousso 2019-05-23 01:20:45 PDT 
I tested this using <https://devinrousso.com/demo/WebKit/bounds.html> :)
Comment 3 WebKit Commit Bot 2019-05-23 17:10:15 PDT 
Comment on attachment 370495 [details]
Patch

Clearing flags on attachment: 370495

Committed r245728: <https://trac.webkit.org/changeset/245728>
Comment 4 WebKit Commit Bot 2019-05-23 17:10:17 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-05-23 17:11:21 PDT 
<rdar://problem/51089099>