Bug 198152 - Deprecate more preview API
Summary: Deprecate more preview API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-22 18:19 PDT by Alex Christensen
Modified: 2019-05-23 10:24 PDT (History)
3 users (show)

See Also:


Attachments
Patch (10.59 KB, patch)
2019-05-22 18:21 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (10.05 KB, patch)
2019-05-22 18:27 PDT, Alex Christensen
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-05-22 18:19:19 PDT
Deprecate more preview API
Comment 1 Alex Christensen 2019-05-22 18:21:31 PDT
Created attachment 370472 [details]
Patch
Comment 2 Alex Christensen 2019-05-22 18:27:22 PDT
Created attachment 370474 [details]
Patch
Comment 3 Dean Jackson 2019-05-23 10:15:54 PDT
Comment on attachment 370474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370474&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKPreviewElementInfo.mm:32
> +#pragma clang diagnostic push
> +#pragma clang diagnostic ignored "-Wdeprecated-implementations"

IGNORE_WARNINGS_BEGIN("deprecated-implementations")

> Source/WebKit/UIProcess/API/Cocoa/WKPreviewElementInfo.mm:34
> +#pragma clang diagnostic pop

IGNORE_WARNINGS_END

> Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.h:70
> +    OptionSet<WebCore::TouchAction> activeTouchActions() const { return m_activeTouchActions; }

Haha
Comment 4 Alex Christensen 2019-05-23 10:21:07 PDT
http://trac.webkit.org/r245691
Comment 5 Radar WebKit Bug Importer 2019-05-23 10:24:33 PDT
<rdar://problem/51072670>