Bug 198150 - release builds of webkit cannot be used to generate a dyld shared cache
Summary: release builds of webkit cannot be used to generate a dyld shared cache
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Stephanie Lewis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-22 17:18 PDT by Stephanie Lewis
Modified: 2019-05-23 14:22 PDT (History)
3 users (show)

See Also:


Attachments
patch (4.25 KB, patch)
2019-05-22 17:26 PDT, Stephanie Lewis
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephanie Lewis 2019-05-22 17:18:55 PDT
https://bugs.webkit.org/show_bug.cgi?id=170385 fixed a warning about Mac OS build sleight of hand for libwebrtc by telling the linker that release builds of WebKit and WebCore will not be placed in a dyld shared cache.  However on some devices this is desirable.  Since we only do the sleight of hand on macosx restrict the flag to macosx.
Comment 1 Stephanie Lewis 2019-05-22 17:21:36 PDT
<rdar://problem/50675982>
Comment 2 Stephanie Lewis 2019-05-22 17:26:25 PDT
Created attachment 370471 [details]
patch
Comment 3 Stephanie Lewis 2019-05-23 14:22:18 PDT
Thanks Dan.

http://trac.webkit.org/projects/webkit/changeset/245717