Bug 198146 - REGRESSION (r240552): PDF contents are not exposed to Accessibility (VO, etc.)
Summary: REGRESSION (r240552): PDF contents are not exposed to Accessibility (VO, etc.)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-22 16:08 PDT by Tim Horton
Modified: 2019-05-22 17:07 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.57 KB, patch)
2019-05-22 16:08 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (6.62 KB, patch)
2019-05-22 16:20 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2019-05-22 16:08:09 PDT 
REGRESSION (r240552): PDF contents are not exposed to Accessibility (VO, etc.)
Comment 1 Tim Horton 2019-05-22 16:08:23 PDT 
Created attachment 370461 [details]
Patch
Comment 2 Tim Horton 2019-05-22 16:08:25 PDT 
<rdar://problem/50698533>
Comment 3 Tim Horton 2019-05-22 16:15:51 PDT 
Comment on attachment 370461 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370461&action=review

> Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:231
> +    [m_mockAccessibilityElement setHasMainFramePlugin:mainFrame()->document()->isPluginDocument()];

Will add a null check here too
Comment 4 Tim Horton 2019-05-22 16:20:04 PDT 
Created attachment 370463 [details]
Patch
Comment 5 WebKit Commit Bot 2019-05-22 17:07:28 PDT 
Comment on attachment 370463 [details]
Patch

Clearing flags on attachment: 370463

Committed r245660: <https://trac.webkit.org/changeset/245660>
Comment 6 WebKit Commit Bot 2019-05-22 17:07:30 PDT 
All reviewed patches have been landed.  Closing bug.