Bug 198143 - [WHLSL] Detection of duplicate functions does not correctly deal with auto-generated setters and getters
Summary: [WHLSL] Detection of duplicate functions does not correctly deal with auto-ge...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-22 15:33 PDT by Robin Morisset
Modified: 2020-05-05 00:42 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2019-05-22 15:33:10 PDT
According to the spec, it is invalid to define an ander and a setter for the same field of the same type, as the ander leads to the creation of a setter, that will conflict with the user-defined one.
Because the implementation currently does not generate setters in this manner, but instead writes their code inline whenever it is needed (https://bugs.webkit.org/show_bug.cgi?id=195925), we won't correctly reject such programs if the ander/setter is never used.

The same problem exists for ander/getter.
Comment 1 Myles C. Maxfield 2019-05-29 13:34:45 PDT
I believe it is no longer possible for a user to define both an ander and a setter for the same field.
Comment 2 Myles C. Maxfield 2019-05-29 13:35:31 PDT
(In reply to Myles C. Maxfield from comment #1)
> I believe it is no longer possible for a user to define both an ander and a
> setter for the same field.

Whoops, disregard this comment, I misread the bug.
Comment 3 Myles C. Maxfield 2020-05-05 00:42:45 PDT
WHLSL is no longer relevant.