Bug 198141 - REGRESSION(r245148): Removing inputmode="none" does not bring up software keyboard
Summary: REGRESSION(r245148): Removing inputmode="none" does not bring up software key...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-22 15:02 PDT by Ryosuke Niwa
Modified: 2019-05-22 17:30 PDT (History)
4 users (show)

See Also:

Attachments
Fixes the bug (6.58 KB, patch)
2019-05-22 15:09 PDT, Ryosuke Niwa 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2019-05-22 15:02:15 PDT 
r245148 changed so that we don't always create UIKeyboard.

This introduced a regression that removing inputmode="none" no longer brings up the keyboard.

<rdar://problem/50613388>
Comment 1 Ryosuke Niwa 2019-05-22 15:09:22 PDT 
Created attachment 370449 [details]
Fixes the bug
Comment 2 Geoffrey Garen 2019-05-22 15:13:48 PDT 
Comment on attachment 370449 [details]
Fixes the bug

r=me
Comment 3 Alexey Proskuryakov 2019-05-22 15:34:12 PDT 
Comment on attachment 370449 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=370449&action=review

> LayoutTests/fast/forms/ios/inputmode-removing-none.html:59
> +//setTimeout(finishJSTest, 7000);

Commented out code.
Comment 4 Ryosuke Niwa 2019-05-22 16:27:14 PDT 
(In reply to Alexey Proskuryakov from comment #3)
> Comment on attachment 370449 [details]
> Fixes the bug
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=370449&action=review
> 
> > LayoutTests/fast/forms/ios/inputmode-removing-none.html:59
> > +//setTimeout(finishJSTest, 7000);
> 
> Commented out code.

Oh oops, will remove that.
Comment 5 Ryosuke Niwa 2019-05-22 17:30:25 PDT 
Committed r245661: <https://trac.webkit.org/changeset/245661>