Bug 198136 - generate-xcfilelists should not store temporary build files in /tmp
Summary: generate-xcfilelists should not store temporary build files in /tmp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-22 12:38 PDT by Keith Rollin
Modified: 2019-05-23 10:33 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.46 KB, patch)
2019-05-22 12:41 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews215 for win-future (13.64 MB, application/zip)
2019-05-22 14:23 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2019-05-22 12:38:40 PDT
Provide the build infrastructure control of the location of generate-xcfilelists' temporary files by creating them in the build directory when possible.

<rdar://problem/49490262>
Comment 1 Keith Rollin 2019-05-22 12:41:44 PDT
Created attachment 370432 [details]
Patch
Comment 2 Jonathan Bedard 2019-05-22 13:16:13 PDT
Comment on attachment 370432 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370432&action=review

> Tools/ChangeLog:10
> +        directory when possible.

This isn't actually accurate, though. We're totally bailing out if we don't have a PROJECT_TEMP_DIR.
Comment 3 Keith Rollin 2019-05-22 13:43:35 PDT
I believe the comment to be accurate. There are five places where temporary files are created. We use the project temp directory in the three places where it's available.
Comment 4 EWS Watchlist 2019-05-22 14:23:20 PDT
Comment on attachment 370432 [details]
Patch

Attachment 370432 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12261166

New failing tests:
fast/block/float/float-with-anonymous-previous-sibling.html
Comment 5 EWS Watchlist 2019-05-22 14:23:23 PDT
Created attachment 370444 [details]
Archive of layout-test-results from ews215 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews215  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 6 Jonathan Bedard 2019-05-22 14:33:19 PDT
(In reply to Keith Rollin from comment #3)
> I believe the comment to be accurate. There are five places where temporary
> files are created. We use the project temp directory in the three places
> where it's available.

I guess the part I'm a bit unclear on is why _get_temp_dir() will fail if we aren't in Xcode. Basically, the 'when possible' part of the comment doesn't seem true to me because if PROJECT_TEMP_DIR isn't available, _generate_derived and _generate_unified will raise exceptions, unless I'm missing something.
Comment 7 Keith Rollin 2019-05-22 15:20:53 PDT
_generate_derived and _generate_unified are only executed within the Xcode context, at which time PROJECT_TEMP_DIR is available and we can make use of it.

set_environment_and_generate is executed outside one the Xcode context, and so PROJECT_TEMP_DIR is not available and so we can't make use of it.
Comment 8 WebKit Commit Bot 2019-05-23 10:33:33 PDT
Comment on attachment 370432 [details]
Patch

Clearing flags on attachment: 370432

Committed r245692: <https://trac.webkit.org/changeset/245692>
Comment 9 WebKit Commit Bot 2019-05-23 10:33:34 PDT
All reviewed patches have been landed.  Closing bug.