Bug 198136 – generate-xcfilelists should not store temporary build files in /tmp

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Keith Rollin]

Provide the build infrastructure control of the location of generate-xcfilelists' temporary files by creating them in the build directory when possible.

<rdar://problem/49490262>

[Keith Rollin]

Created attachment 370432 [details]
Patch

[Jonathan Bedard]

Comment on attachment 370432 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370432&action=review

> Tools/ChangeLog:10
> +        directory when possible.

This isn't actually accurate, though. We're totally bailing out if we don't have a PROJECT_TEMP_DIR.

[Keith Rollin]

I believe the comment to be accurate. There are five places where temporary files are created. We use the project temp directory in the three places where it's available.

[EWS Watchlist]

Comment on attachment 370432 [details]
Patch

Attachment 370432 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12261166

New failing tests:
fast/block/float/float-with-anonymous-previous-sibling.html

[EWS Watchlist]

Created attachment 370444 [details]
Archive of layout-test-results from ews215 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews215  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Jonathan Bedard]

(In reply to Keith Rollin from comment #3)
> I believe the comment to be accurate. There are five places where temporary
> files are created. We use the project temp directory in the three places
> where it's available.

I guess the part I'm a bit unclear on is why _get_temp_dir() will fail if we aren't in Xcode. Basically, the 'when possible' part of the comment doesn't seem true to me because if PROJECT_TEMP_DIR isn't available, _generate_derived and _generate_unified will raise exceptions, unless I'm missing something.

[Keith Rollin]

_generate_derived and _generate_unified are only executed within the Xcode context, at which time PROJECT_TEMP_DIR is available and we can make use of it.

set_environment_and_generate is executed outside one the Xcode context, and so PROJECT_TEMP_DIR is not available and so we can't make use of it.

[WebKit Commit Bot]

Comment on attachment 370432 [details]
Patch

Clearing flags on attachment: 370432

Committed r245692: <https://trac.webkit.org/changeset/245692>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.