<rdar://problem/51001306>
Created attachment 370433 [details] Patch
Thanks for the review! > fast/visual-viewport/rtl-nonzoomed-rects.html [ Failure ] > fast/visual-viewport/rtl-zoomed-rects.html [ Failure ] > fast/visual-viewport/rubberbanding-viewport-rects-extended-background.html [ Failure ] > fast/visual-viewport/rubberbanding-viewport-rects-header-footer.html [ Failure ] > fast/visual-viewport/rubberbanding-viewport-rects.html [ Failure ] > fast/visual-viewport/viewport-dimensions.html [ Failure ] > fast/visual-viewport/zoomed-fixed-header-and-footer.html [ Failure ] > fast/visual-viewport/zoomed-fixed-scroll-down-then-up.html [ Failure ] > fast/visual-viewport/zoomed-fixed.html [ Failure ] > fast/visual-viewport/zoomed-rects.html [ Failure ] ...so these started failing after I _fixed_ the timeouts in the other viewport tests :( It seems these tests currently rely on the viewport tests timing out. I'll look into these test failures and find a way to fix them.
Comment on attachment 370433 [details] Patch Attachment 370433 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12261482 New failing tests: js/dom/custom-constructors.html
Created attachment 370450 [details] Archive of layout-test-results from ews210 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews210 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
(In reply to Wenson Hsieh from comment #2) > Thanks for the review! > > > fast/visual-viewport/rtl-nonzoomed-rects.html [ Failure ] > > fast/visual-viewport/rtl-zoomed-rects.html [ Failure ] > > fast/visual-viewport/rubberbanding-viewport-rects-extended-background.html [ Failure ] > > fast/visual-viewport/rubberbanding-viewport-rects-header-footer.html [ Failure ] > > fast/visual-viewport/rubberbanding-viewport-rects.html [ Failure ] > > fast/visual-viewport/viewport-dimensions.html [ Failure ] > > fast/visual-viewport/zoomed-fixed-header-and-footer.html [ Failure ] > > fast/visual-viewport/zoomed-fixed-scroll-down-then-up.html [ Failure ] > > fast/visual-viewport/zoomed-fixed.html [ Failure ] > > fast/visual-viewport/zoomed-rects.html [ Failure ] > > ...so these started failing after I _fixed_ the timeouts in the other > viewport tests :( > > It seems these tests currently rely on the viewport tests timing out. I'll > look into these test failures and find a way to fix them. Actually, I'm able to reproduce these failures locally, even without my patch 🤔. I don't quite grok what's going on, but I have a feeling this may be a manifestation of <rdar://problem/50501718>. I'll re-upload my patch to run against EWS again, and see how it fares.
Created attachment 370459 [details] For EWS
Comment on attachment 370459 [details] For EWS Clearing flags on attachment: 370459 Committed r245663: <https://trac.webkit.org/changeset/245663>
All reviewed patches have been landed. Closing bug.
*** Bug 198085 has been marked as a duplicate of this bug. ***