Bug 198125 - [WPE] Build fails with ENABLE_VIDEO=OFF and ENABLE_WEB_AUDIO=OFF
Summary: [WPE] Build fails with ENABLE_VIDEO=OFF and ENABLE_WEB_AUDIO=OFF
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-22 09:25 PDT by Adrian Perez
Modified: 2019-05-23 00:29 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.23 KB, patch)
2019-05-22 09:45 PDT, Adrian Perez 		no flags Details | Formatted Diff | Diff
Patch v2 (1.88 KB, patch)
2019-05-22 10:24 PDT, Adrian Perez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2019-05-22 09:25:32 PDT 
Probably this affects the GTK port as well. Build error follows:

---

In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-17.cpp:2:
../Source/WebKit/WebProcess/glib/WebProcessGLib.cpp:31:10: fatal error: WebCore/GStreamerCommon.h: No such file or directory
 #include <WebCore/GStreamerCommon.h>
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
Comment 1 Adrian Perez 2019-05-22 09:45:36 PDT 
Created attachment 370406 [details]
Patch
Comment 2 Adrian Perez 2019-05-22 09:48:28 PDT 
Comment on attachment 370406 [details]
Patch

I'll have to update this patch, there is another error after
fixing the first one:

../Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp:34:10: fatal error: WebCore/GStreamerCommon.h: No such file or directory
 #include <WebCore/GStreamerCommon.h>
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
Comment 3 Adrian Perez 2019-05-22 10:24:57 PDT 
Created attachment 370416 [details]
Patch v2
Comment 4 Philippe Normand 2019-05-23 00:13:49 PDT 
Comment on attachment 370416 [details]
Patch v2

👍
Comment 5 WebKit Commit Bot 2019-05-23 00:28:30 PDT 
Comment on attachment 370416 [details]
Patch v2

Clearing flags on attachment: 370416

Committed r245676: <https://trac.webkit.org/changeset/245676>
Comment 6 WebKit Commit Bot 2019-05-23 00:28:32 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-05-23 00:29:19 PDT 
<rdar://problem/51058526>