Bug 198118 - [GTK] media/playlist-inherits-user-gesture.html is timing out
Summary: [GTK] media/playlist-inherits-user-gesture.html is timing out
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-22 08:01 PDT by Alicia Boya García
Modified: 2021-07-12 08:42 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.42 KB, patch)
2021-07-12 08:05 PDT, Arcady Goldmints-Orlov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alicia Boya García 2019-05-22 08:01:38 PDT
media/playlist-inherits-user-gesture.html

Timing out since r245462:r245467

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/media/playlist-inherits-user-gesture-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/media/playlist-inherits-user-gesture-actual.txt
@@ -1,27 +1,3 @@
-** Start first video with user gesture.
-RUN(window.internals.settings.setVideoPlaybackRequiresUserGesture(true);)
-RUN(video1 = document.createElement("video"))
-RUN(video1.src = findMediaFile("video", "content/test"))
-RUN(document.body.appendChild(video1))
-EXPECTED (window.internals.pageMediaState().includes('HasUserInteractedWithMediaElement') == 'false') OK
-RUN(video1.play())
-EXPECTED (window.internals.pageMediaState().includes('HasUserInteractedWithMediaElement') == 'true') OK
-EVENT(playing)
-RUN(video1.currentTime = video1.duration - 0.2)
-EVENT(ended)
+CONSOLE MESSAGE: line 35: Unhandled Promise Rejection: NotAllowedError: The request is not allowed by the user agent or the platform in the current context, possibly because the user denied permission.
+FAIL: Timed out waiting for notifyDone to be called
 
-** Start second video without user gesture but within inheritance window, should succeed.
-RUN(video2 = document.createElement("video"))
-RUN(video2.src = findMediaFile("video", "content/test"))
-RUN(document.body.appendChild(video2))
-Promise resolved OK
-RUN(video2.currentTime = video2.duration - 0.2)
-EVENT(ended)
-
-** Start third video without user gesture but after inheritance window, should fail.
-RUN(video3 = document.createElement("video"))
-RUN(video3.src = findMediaFile("video", "content/test"))
-RUN(document.body.appendChild(video3))
-Promise rejected correctly OK
-END OF TEST
-
Comment 1 Arcady Goldmints-Orlov 2021-07-12 08:02:02 PDT
This appears to be fixed by r279289.
Comment 2 Arcady Goldmints-Orlov 2021-07-12 08:05:15 PDT
Created attachment 433318 [details]
Patch
Comment 3 Philippe Normand 2021-07-12 08:13:47 PDT
(In reply to Arcady Goldmints-Orlov from comment #1)
> This appears to be fixed by r279289.

Yes, good catch.
Comment 4 EWS 2021-07-12 08:41:59 PDT
Committed r279828 (239589@main): <https://commits.webkit.org/239589@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433318 [details].