Bug 198100 - [Apple] Enable variation fonts on all Apple platforms
Summary: [Apple] Enable variation fonts on all Apple platforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-21 19:06 PDT by Myles C. Maxfield
Modified: 2019-11-16 00:19 PST (History)
12 users (show)

See Also:


Attachments
Patch (9.01 KB, patch)
2019-05-21 19:06 PDT, Myles C. Maxfield
simon.fraser: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch for committing (8.88 KB, patch)
2019-11-15 17:03 PST, Myles C. Maxfield
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2019-05-21 19:06:09 PDT
[Apple] Enable variation fonts on all Apple platforms
Comment 1 Myles C. Maxfield 2019-05-21 19:06:33 PDT
Created attachment 370371 [details]
Patch
Comment 2 EWS Watchlist 2019-05-21 19:08:47 PDT
Attachment 370371 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2019-06-16 20:49:12 PDT
Still relevant?
Comment 4 WebKit Commit Bot 2019-11-15 15:57:02 PST
Comment on attachment 370371 [details]
Patch

Rejecting attachment 370371 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 370371, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=370371&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=198100&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 370371 from bug 198100.
Fetching: https://bugs.webkit.org/attachment.cgi?id=370371
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Simon Fraser']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 12 diffs from patch file(s).
patching file Source/JavaScriptCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/PAL/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKitLegacy/mac/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig
Hunk #1 FAILED at 380.
1 out of 1 hunk FAILED -- saving rejects to file Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig.rej
patching file Source/WebCore/Configurations/FeatureDefines.xcconfig
Hunk #1 FAILED at 380.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/Configurations/FeatureDefines.xcconfig.rej
patching file Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig
Hunk #1 FAILED at 380.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig.rej
patching file Source/WebKit/Configurations/FeatureDefines.xcconfig
Hunk #1 FAILED at 380.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/Configurations/FeatureDefines.xcconfig.rej
patching file Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig
Hunk #1 FAILED at 380.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig.rej
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig
Hunk #1 FAILED at 380.
1 out of 1 hunk FAILED -- saving rejects to file Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Simon Fraser']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/13259356
Comment 5 Myles C. Maxfield 2019-11-15 17:03:36 PST
Created attachment 383668 [details]
Patch for committing
Comment 6 WebKit Commit Bot 2019-11-15 17:48:52 PST
Comment on attachment 383668 [details]
Patch for committing

Clearing flags on attachment: 383668

Committed r252516: <https://trac.webkit.org/changeset/252516>
Comment 7 Radar WebKit Bug Importer 2019-11-16 00:19:22 PST
<rdar://problem/57251386>