Bug 198088 - Web Inspector: Overlay: rulers/guides should be shown whenever element selection is enabled
Summary: Web Inspector: Overlay: rulers/guides should be shown whenever element select...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-21 15:10 PDT by Devin Rousso
Modified: 2019-05-23 18:37 PDT (History)
11 users (show)

See Also:

Attachments
Patch (5.33 KB, patch)
2019-05-22 22:36 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (18.61 KB, patch)
2019-05-23 17:52 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (18.73 KB, patch)
2019-05-23 18:06 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-05-21 15:10:32 PDT 
This would be especially useful when element selection is started from the develop menu (⇧⌘C), instead of from the Web Inspector UI.
Comment 1 Devin Rousso 2019-05-22 22:36:56 PDT 
Created attachment 370488 [details]
Patch
Comment 2 Timothy Hatcher 2019-05-23 10:45:14 PDT 
I'm on the fence about this. If a developer hates rulers, they would be turned off by this. Maybe a setting in in order for this behavior?
Comment 3 Devin Rousso 2019-05-23 17:52:25 PDT 
Created attachment 370535 [details]
Patch

Added a setting that is enabled by default :)
Comment 4 Devin Rousso 2019-05-23 18:06:20 PDT 
Created attachment 370536 [details]
Patch

Rebase
Comment 5 EWS Watchlist 2019-05-23 18:08:30 PDT 
This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.
Comment 6 WebKit Commit Bot 2019-05-23 18:34:38 PDT 
Comment on attachment 370536 [details]
Patch

Clearing flags on attachment: 370536

Committed r245730: <https://trac.webkit.org/changeset/245730>
Comment 7 WebKit Commit Bot 2019-05-23 18:34:40 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-05-23 18:37:38 PDT 
<rdar://problem/51091474>