Bug 198087 - WHLSL: fix enum parsing
Summary: WHLSL: fix enum parsing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-21 15:06 PDT by Saam Barati
Modified: 2019-05-22 17:35 PDT (History)
7 users (show)

See Also:

Attachments
WIP (46.56 KB, patch)
2019-05-21 20:04 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (11.35 KB, patch)
2019-05-21 22:00 PDT, Saam Barati 		mmaxfield: review+
Details | Formatted Diff | Diff
patch for landing (11.36 KB, patch)
2019-05-22 16:43 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2019-05-21 15:06:14 PDT 
...
Comment 1 Saam Barati 2019-05-21 19:38:58 PDT 
Doing this next.
Comment 2 Saam Barati 2019-05-21 20:04:18 PDT 
Created attachment 370375 [details]
WIP

contains all the dumper code. Will rebase once that lands.
Comment 3 Saam Barati 2019-05-21 22:00:15 PDT 
Created attachment 370380 [details]
patch
Comment 4 Saam Barati 2019-05-21 22:00:56 PDT 
Comment on attachment 370380 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370380&action=review

> LayoutTests/webgpu/whlsl-dont-crash-parsing-enum.html:1
> +<!DOCTYPE html>

Will try to reduce this test case to just run the WHLSL parser. But I don't have a build yet to get against. Will fix for final patch.
Comment 5 Myles C. Maxfield 2019-05-22 09:57:05 PDT 
Comment on attachment 370380 [details]
patch

Thanks for catching this! Is this the only place in the file where this bad pattern occurs?
Comment 6 Saam Barati 2019-05-22 13:58:10 PDT 
(In reply to Myles C. Maxfield from comment #5)
> Comment on attachment 370380 [details]
> patch
> 
> Thanks for catching this! Is this the only place in the file where this bad
> pattern occurs?

Which file are we talking about here?

(Maybe we should make the name() method not return "String&").
Comment 7 Saam Barati 2019-05-22 16:25:09 PDT 
Comment on attachment 370380 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370380&action=review

>> LayoutTests/webgpu/whlsl-dont-crash-parsing-enum.html:1
>> +<!DOCTYPE html>
> 
> Will try to reduce this test case to just run the WHLSL parser. But I don't have a build yet to get against. Will fix for final patch.

gonna just stick with this.
Comment 8 Saam Barati 2019-05-22 16:43:32 PDT 
Created attachment 370466 [details]
patch for landing
Comment 9 WebKit Commit Bot 2019-05-22 17:33:52 PDT 
Comment on attachment 370466 [details]
patch for landing

Clearing flags on attachment: 370466

Committed r245662: <https://trac.webkit.org/changeset/245662>
Comment 10 WebKit Commit Bot 2019-05-22 17:33:53 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2019-05-22 17:35:28 PDT 
<rdar://problem/51049758>