Bug 198078 - Implement Feature policy self/none/* parsing
Summary: Implement Feature policy self/none/* parsing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-21 11:43 PDT by youenn fablet
Modified: 2019-05-22 10:39 PDT (History)
7 users (show)

See Also:

Attachments
Patch (30.50 KB, patch)
2019-05-21 12:46 PDT, youenn fablet 		ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-highsierra-wk2 (3.14 MB, application/zip)
2019-05-21 14:16 PDT, EWS Watchlist 		no flags Details
Patch (33.35 KB, patch)
2019-05-21 14:31 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (33.94 KB, patch)
2019-05-21 15:47 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (34.01 KB, patch)
2019-05-21 18:07 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (34.06 KB, patch)
2019-05-22 08:38 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (34.05 KB, patch)
2019-05-22 09:57 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-05-21 11:43:07 PDT 
Implement Feature policy self/none/* parsing
Comment 1 youenn fablet 2019-05-21 12:46:04 PDT 
Created attachment 370334 [details]
Patch
Comment 2 youenn fablet 2019-05-21 12:47:28 PDT 
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/16940
Comment 3 EWS Watchlist 2019-05-21 14:16:39 PDT 
Comment on attachment 370334 [details]
Patch

Attachment 370334 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12249589

New failing tests:
http/tests/media/media-stream/get-display-media-iframe-allow-attribute.html
Comment 4 EWS Watchlist 2019-05-21 14:16:41 PDT 
Created attachment 370341 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 5 youenn fablet 2019-05-21 14:31:43 PDT 
Created attachment 370342 [details]
Patch
Comment 6 youenn fablet 2019-05-21 15:47:18 PDT 
Created attachment 370348 [details]
Patch
Comment 7 Eric Carlson 2019-05-21 16:29:10 PDT 
Comment on attachment 370348 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370348&action=review

> Source/WebCore/html/FeaturePolicy.cpp:121
> +    if (!isCameraInitialized)

I don’t understand why we add the origin to the allowed list if “camera” is NOT in the attribute, so it is probably worth adding a comment here to explain.
Comment 8 youenn fablet 2019-05-21 17:02:32 PDT 
(In reply to Eric Carlson from comment #7)
> Comment on attachment 370348 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=370348&action=review
> 
> > Source/WebCore/html/FeaturePolicy.cpp:121
> > +    if (!isCameraInitialized)
> 
> I don’t understand why we add the origin to the allowed list if “camera” is
> NOT in the attribute, so it is probably worth adding a comment here to
> explain.

OK.
The reason is that the default policy is 'self' for camera, microphone and display-capture.
Comment 9 youenn fablet 2019-05-21 18:07:45 PDT 
Created attachment 370363 [details]
Patch for landing
Comment 10 youenn fablet 2019-05-22 08:38:02 PDT 
Created attachment 370399 [details]
Patch for landing
Comment 11 WebKit Commit Bot 2019-05-22 09:12:57 PDT 
Comment on attachment 370399 [details]
Patch for landing

Rejecting attachment 370399 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 370399, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/12257936
Comment 12 youenn fablet 2019-05-22 09:57:38 PDT 
Created attachment 370412 [details]
Patch for landing
Comment 13 WebKit Commit Bot 2019-05-22 10:38:48 PDT 
Comment on attachment 370412 [details]
Patch for landing

Clearing flags on attachment: 370412

Committed r245625: <https://trac.webkit.org/changeset/245625>
Comment 14 WebKit Commit Bot 2019-05-22 10:38:50 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 15 Radar WebKit Bug Importer 2019-05-22 10:39:22 PDT 
<rdar://problem/51032586>