Bug 198078 – Implement Feature policy self/none/* parsing

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Implement Feature policy self/none/* parsing

[youenn fablet]

Created attachment 370334 [details]
Patch

[youenn fablet]

Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/16940

[EWS Watchlist]

Comment on attachment 370334 [details]
Patch

Attachment 370334 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12249589

New failing tests:
http/tests/media/media-stream/get-display-media-iframe-allow-attribute.html

[EWS Watchlist]

Created attachment 370341 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[youenn fablet]

Created attachment 370342 [details]
Patch

[youenn fablet]

Created attachment 370348 [details]
Patch

[Eric Carlson]

Comment on attachment 370348 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370348&action=review

> Source/WebCore/html/FeaturePolicy.cpp:121
> +    if (!isCameraInitialized)

I don’t understand why we add the origin to the allowed list if “camera” is NOT in the attribute, so it is probably worth adding a comment here to explain.

[youenn fablet]

(In reply to Eric Carlson from comment #7)
> Comment on attachment 370348 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=370348&action=review
> 
> > Source/WebCore/html/FeaturePolicy.cpp:121
> > +    if (!isCameraInitialized)
> 
> I don’t understand why we add the origin to the allowed list if “camera” is
> NOT in the attribute, so it is probably worth adding a comment here to
> explain.

OK.
The reason is that the default policy is 'self' for camera, microphone and display-capture.

[youenn fablet]

Created attachment 370363 [details]
Patch for landing

[youenn fablet]

Created attachment 370399 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 370399 [details]
Patch for landing

Rejecting attachment 370399 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 370399, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/12257936

[youenn fablet]

Created attachment 370412 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 370412 [details]
Patch for landing

Clearing flags on attachment: 370412

Committed r245625: <https://trac.webkit.org/changeset/245625>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/51032586>