WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
198076
[ews-build] Use custom templates for Buildbot
https://bugs.webkit.org/show_bug.cgi?id=198076
Summary
[ews-build] Use custom templates for Buildbot
Aakash Jain
Reported
2019-05-21 11:11:47 PDT
Use custom templates for Buildbot UI.
Attachments
Patch
(3.32 KB, patch)
2019-05-21 11:21 PDT
,
Aakash Jain
no flags
Details
Formatted Diff
Diff
Proposed patch
(3.82 KB, patch)
2019-05-21 16:08 PDT
,
Aakash Jain
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2019-05-21 11:12:22 PDT
<
rdar://problem/50992485
>
Aakash Jain
Comment 2
2019-05-21 11:21:04 PDT
Created
attachment 370330
[details]
Patch
Jonathan Bedard
Comment 3
2019-05-21 16:00:24 PDT
Comment on
attachment 370330
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=370330&action=review
> Tools/ChangeLog:8 > + * BuildSlaveSupport/ews-build/master.cfg:
Why is this here? It wasn't edited.
> Tools/BuildSlaveSupport/ews-build/templates/build.jade:1 > +.container
Can I see a screen shot of this? It's clearly rending HTML...but it's tough to parse, especially so since we don't have any .jade in the tree yet.
Aakash Jain
Comment 4
2019-05-21 16:08:03 PDT
Comment on
attachment 370330
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=370330&action=review
>> Tools/ChangeLog:8 >> + * BuildSlaveSupport/ews-build/master.cfg: > > Why is this here? It wasn't edited.
good catch. missed it while creating the patch. Added in updated patch.
>> Tools/BuildSlaveSupport/ews-build/templates/build.jade:1 >> +.container > > Can I see a screen shot of this? > > It's clearly rending HTML...but it's tough to parse, especially so since we don't have any .jade in the tree yet.
It's deployed on ews-build.webkit-uat.org, you can check any build on it.
Aakash Jain
Comment 5
2019-05-21 16:08:48 PDT
Created
attachment 370353
[details]
Proposed patch
Jonathan Bedard
Comment 6
2019-05-21 16:14:17 PDT
RS=me
Aakash Jain
Comment 7
2019-05-21 17:34:18 PDT
Committed
r245603
: <
https://trac.webkit.org/changeset/245603
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug