Bug 198069 - Undefined reference platformCloseFrontendPageAndWindow() linking against libWPEWebKit-1.0.so after r245536
Summary: Undefined reference platformCloseFrontendPageAndWindow() linking against libW...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pablo Saavedra
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-21 02:51 PDT by Pablo Saavedra
Modified: 2019-05-21 11:00 PDT (History)
8 users (show)

See Also:

Attachments
patch (1.31 KB, patch)
2019-05-21 02:54 PDT, Pablo Saavedra 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pablo Saavedra 2019-05-21 02:51:57 PDT 
Undefined reference platformCloseFrontendPageAndWindow() linking against libWPEWebKit-1.0.so after r245536

I got this linking time issue trying to build Cog (the reference browser for WPE in meta-webkit - https://github.com/Igalia/cog) against the latest master:


```  
libWPEWebKit-1.0.so: undefined reference to `WebKit::RemoteWebInspectorProxy::platformCloseFrontendPageAndWindow()'
```

The issues was introduced in 

  [WinCairo] Implement Remote Web Inspector Client.
  https://bugs.webkit.org/show_bug.cgi?id=197434

The WPE platform still needs a dummy definition of `WebPageProxy* RemoteWebInspectorProxy::platformCreateFrontendPageAndWindow()`

Uploaded a patch with a proposal for change
Comment 1 Pablo Saavedra 2019-05-21 02:54:40 PDT 
Created attachment 370306 [details]
patch
Comment 2 Ross Kirsling 2019-05-21 08:22:00 PDT 
Comment on attachment 370306 [details]
patch

Thanks -- sorry for the trouble!
Comment 3 WebKit Commit Bot 2019-05-21 10:57:50 PDT 
Comment on attachment 370306 [details]
patch

Clearing flags on attachment: 370306

Committed r245587: <https://trac.webkit.org/changeset/245587>
Comment 4 WebKit Commit Bot 2019-05-21 10:57:52 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-05-21 11:00:38 PDT 
<rdar://problem/50991894>