Bug 198068 - [WebAuthN] Make WebAuthN default on only on macOS
Summary: [WebAuthN] Make WebAuthN default on only on macOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks: 181943
  Show dependency treegraph
 
Reported: 2019-05-20 20:43 PDT by Jiewen Tan
Modified: 2019-05-21 13:26 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.84 KB, patch)
2019-05-20 20:52 PDT, Jiewen Tan
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews215 for win-future (13.63 MB, application/zip)
2019-05-21 03:24 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2019-05-20 20:43:35 PDT
Make WebAuthN default on only on macOS.
Comment 1 Radar WebKit Bug Importer 2019-05-20 20:44:31 PDT
<rdar://problem/50971874>
Comment 2 Radar WebKit Bug Importer 2019-05-20 20:44:33 PDT Comment hidden (obsolete)
Comment 3 Jiewen Tan 2019-05-20 20:52:34 PDT
Created attachment 370298 [details]
Patch
Comment 4 Build Bot 2019-05-21 03:24:13 PDT Comment hidden (obsolete)
Comment 5 Build Bot 2019-05-21 03:24:14 PDT Comment hidden (obsolete)
Comment 6 Brent Fulgham 2019-05-21 07:58:56 PDT
Comment on attachment 370298 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370298&action=review

> Source/WebKit/Shared/WebPreferencesDefaultValues.h:276
> +#if PLATFORM(MAC)

Do any other ports support iOS?
Comment 7 Jiewen Tan 2019-05-21 11:33:38 PDT
WebAuthN is disabled by a compile time flag in Win ports, and therefore I don't believe those test failures are related.
Comment 8 Jiewen Tan 2019-05-21 11:36:34 PDT
(In reply to Brent Fulgham from comment #6)
> Comment on attachment 370298 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=370298&action=review
> 
> > Source/WebKit/Shared/WebPreferencesDefaultValues.h:276
> > +#if PLATFORM(MAC)
> 
> Do any other ports support iOS?

I don't think so. The compile time flag is on only for macOS and iOS, and therefore other ports are off by default.

Thanks Brent for r+ this patch.
Comment 9 WebKit Commit Bot 2019-05-21 12:04:03 PDT
Comment on attachment 370298 [details]
Patch

Clearing flags on attachment: 370298

Committed r245589: <https://trac.webkit.org/changeset/245589>
Comment 10 WebKit Commit Bot 2019-05-21 12:04:05 PDT
All reviewed patches have been landed.  Closing bug.