Bug 198068 – [WebAuthN] Make WebAuthN default on only on macOS

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Jiewen Tan]

Make WebAuthN default on only on macOS.

[Radar WebKit Bug Importer]

<rdar://problem/50971874>

[Radar WebKit Bug Importer]

<rdar://problem/50971875>

[Jiewen Tan]

Created attachment 370298 [details]
Patch

[EWS Watchlist]

Comment on attachment 370298 [details]
Patch

Attachment 370298 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12244932

New failing tests:
fast/block/float/float-with-anonymous-previous-sibling.html

[EWS Watchlist]

Created attachment 370309 [details]
Archive of layout-test-results from ews215 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews215  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Brent Fulgham]

Comment on attachment 370298 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370298&action=review

> Source/WebKit/Shared/WebPreferencesDefaultValues.h:276
> +#if PLATFORM(MAC)

Do any other ports support iOS?

[Jiewen Tan]

WebAuthN is disabled by a compile time flag in Win ports, and therefore I don't believe those test failures are related.

[Jiewen Tan]

(In reply to Brent Fulgham from comment #6)
> Comment on attachment 370298 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=370298&action=review
> 
> > Source/WebKit/Shared/WebPreferencesDefaultValues.h:276
> > +#if PLATFORM(MAC)
> 
> Do any other ports support iOS?

I don't think so. The compile time flag is on only for macOS and iOS, and therefore other ports are off by default.

Thanks Brent for r+ this patch.

[WebKit Commit Bot]

Comment on attachment 370298 [details]
Patch

Clearing flags on attachment: 370298

Committed r245589: <https://trac.webkit.org/changeset/245589>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.