NEW198066
Remove unnecessary duplicate selector invocations 
https://bugs.webkit.org/show_bug.cgi?id=198066
Summary Remove unnecessary duplicate selector invocations
Joseph Pecoraro
Reported 2019-05-20 20:37:07 PDT
Remove unnecessary duplicate selector invocations - [NSNotificationCenter defaultCenter] - [NSDistributedNotificationCenter defaultCenter] - [NSUserDefaults standardUserDefaults] - [NSFileManager defaultManager] Avoid multiple msgSends if these are frequent in a method.
Attachments
[PATCH] Proposed Fix (69.12 KB, patch)
2019-05-20 20:49 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (69.20 KB, patch)
2019-05-20 22:34 PDT, Joseph Pecoraro 		achristensen: review+
DetailsFormatted DiffDiff
[PATCH] For Landing (69.29 KB, patch)
2019-05-21 10:53 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2019-05-20 20:49:30 PDT
Created attachment 370297 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 2 2019-05-20 22:34:09 PDT
Created attachment 370299 [details] [PATCH] Proposed Fix
Alex Christensen
Comment 3 2019-05-21 10:22:12 PDT
Comment on attachment 370299 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=370299&action=review > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:409 > + NSNotificationCenter *center = [NSNotificationCenter defaultCenter]; This needs to be outside the guard.
Joseph Pecoraro
Comment 4 2019-05-21 10:53:39 PDT
Created attachment 370326 [details] [PATCH] For Landing
Note You need to log in before you can comment on or make changes to this bug.