Bug 198055 – [Meta][WinCairo] Enable WebDriver

• Status: RESOLVED
• Resolution: FIXED
• Component: WebDriver

[Don Olmstead]

WebDriver support is nice to have.

[haruhisa.shin]

Pull request: https://github.com/WebKit/WebKit/pull/23847

[EWS]

Committed 274530@main (db706f64b581): <https://commits.webkit.org/274530@main>

Reviewed commits have been landed. Closing PR #23847 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/122855467>

[Fujii Hironori]

Debug build is crashing. I'm going to revert. PTAL.

Buildbot: builder WinCairo-64-bit-Debug-Tests build 21837 : 274532@main
https://build.webkit.org/#/builders/727/builds/21837

ASSERTION FAILED: (m_client && !client) || (!m_client && client)
C:\BW\WinCairo-64-bit-Debug-Build\build\Source\JavaScriptCore\inspector/remote/RemoteInspector.cpp(166) : setClient
1   00007FF8F5DD1CA9 WTFCrash
2   00007FF8E80E383D WTFCrashWithInfo
3   00007FF8E90F17DD Inspector::RemoteInspector::setClient
4   00007FF8EA6213B2 WebKit::AutomationClient::AutomationClient
5   00007FF8EA6342D7 std::make_unique<WebKit::AutomationClient,WebKit::WebProcessPool &,0>
6   00007FF8EA632EB0 WTF::makeUnique<WebKit::AutomationClient,WebKit::WebProcessPool &>
7   00007FF8EA6328CF WebKit::WebProcessPool::platformInitialize
8   00007FF8EB6F4108 WebKit::WebProcessPool::WebProcessPool
9   00007FF8EB6F36DC WebKit::WebProcessPool::create
10  00007FF8EB87BC10 WKContextCreateWithConfiguration
11  00007FF64CA1F65D WTR::TestController::generatePageConfiguration
12  00007FF64CA20806 WTR::TestController::createWebViewWithOptions
13  00007FF64CA21520 WTR::TestController::ensureViewSupportsOptionsForTest
14  00007FF64CA24052 WTR::TestController::configureViewForTest
15  00007FF64CA78C4A WTR::TestInvocation::invoke
16  00007FF64CA24378 WTR::TestController::runTest
17  00007FF64CA2462E WTR::TestController::runTestingServerLoop
18  00007FF64CA1D1D7 WTR::TestController::run
19  00007FF64CA1CDCA WTR::TestController::TestController
20  00007FF64CAA8F8D main
21  00007FF64CE8F674 __scrt_common_main_seh
22  00007FF904EF4DE0 BaseThreadInitThunk
23  00007FF91541EC4B RtlUserThreadStart

[haruhisa.shin]

(In reply to Fujii Hironori from comment #4)
> Debug build is crashing. I'm going to revert. PTAL.
> 
> Buildbot: builder WinCairo-64-bit-Debug-Tests build 21837 : 274532@main
> https://build.webkit.org/#/builders/727/builds/21837
> 
> ASSERTION FAILED: (m_client && !client) || (!m_client && client)
> C:\BW\WinCairo-64-bit-Debug-Build\build\Source\JavaScriptCore\inspector/
> remote/RemoteInspector.cpp(166) : setClient
> 1   00007FF8F5DD1CA9 WTFCrash
> 2   00007FF8E80E383D WTFCrashWithInfo
> 3   00007FF8E90F17DD Inspector::RemoteInspector::setClient
> 4   00007FF8EA6213B2 WebKit::AutomationClient::AutomationClient
> 5   00007FF8EA6342D7
> std::make_unique<WebKit::AutomationClient,WebKit::WebProcessPool &,0>
> 6   00007FF8EA632EB0
> WTF::makeUnique<WebKit::AutomationClient,WebKit::WebProcessPool &>
> 7   00007FF8EA6328CF WebKit::WebProcessPool::platformInitialize
> 8   00007FF8EB6F4108 WebKit::WebProcessPool::WebProcessPool
> 9   00007FF8EB6F36DC WebKit::WebProcessPool::create
> 10  00007FF8EB87BC10 WKContextCreateWithConfiguration
> 11  00007FF64CA1F65D WTR::TestController::generatePageConfiguration
> 12  00007FF64CA20806 WTR::TestController::createWebViewWithOptions
> 13  00007FF64CA21520 WTR::TestController::ensureViewSupportsOptionsForTest
> 14  00007FF64CA24052 WTR::TestController::configureViewForTest
> 15  00007FF64CA78C4A WTR::TestInvocation::invoke
> 16  00007FF64CA24378 WTR::TestController::runTest
> 17  00007FF64CA2462E WTR::TestController::runTestingServerLoop
> 18  00007FF64CA1D1D7 WTR::TestController::run
> 19  00007FF64CA1CDCA WTR::TestController::TestController
> 20  00007FF64CAA8F8D main
> 21  00007FF64CE8F674 __scrt_common_main_seh
> 22  00007FF904EF4DE0 BaseThreadInitThunk
> 23  00007FF91541EC4B RtlUserThreadStart

Thank you for the information. I will confirm today.

[haruhisa.shin]

The socket port implementation can only hold one JSC::RemoteInspector::Client.
However, when two or more WebContext(WebProcessPool) were created, each would attempt to set the JSC::RemoteInspector::Client, resulting in the above assertion.

One test before "animation/cross-fade-background-image.html" is "animation/crash-on-removing-animation.html".
This test caused WTR to restart, which generated a second WebContext, thus causing the above assertion.
Also, when "New Window" was executed in MiniBrowser, multiple WebContxts were created and the same assertion occurred.

To fix this problem, in the WebProessPool::platformInitialize(), do not create a new AutomationClient if JSC::RemoteInspector::Client is already set.
This means that only the first generated WebContext can be manipulated by WebDriver.

[haruhisa.shin]

Pull request: https://github.com/WebKit/WebKit/pull/24495

[EWS]

Committed 274762@main (b09419cb34e8): <https://commits.webkit.org/274762@main>

Reviewed commits have been landed. Closing PR #24495 and removing active labels.