RESOLVED FIXED 19804
optimize access to arrays without "holes" 
https://bugs.webkit.org/show_bug.cgi?id=19804
Summary optimize access to arrays without "holes"
Darin Adler
Reported 2008-06-28 17:52:25 PDT
I can speed up SunSpider almost 2% by optimizing access to the parts of arrays before any "missing values".
Attachments
patch (15.45 KB, patch)
2008-06-28 18:02 PDT, Darin Adler 		zwarich: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2008-06-28 18:02:18 PDT
Created attachment 21991 [details] patch
Cameron Zwarich (cpst)
Comment 2 2008-06-28 18:21:40 PDT
Comment on attachment 21991 [details] patch r=me There are some typos in the ChangeLog.
Cameron Zwarich (cpst)
Comment 3 2008-06-28 18:30:08 PDT
Sam pointed out in the channel that you forgot to remove the declaration for JSArray::inlineGetOwnPropertySlot, and that the getOwnPropertySlotSlowCase may be a better name for getSlowCase. Definitely remove the declaration before landing, but what do you think about his suggestion about the name change for getSlowCase?
Darin Adler
Comment 4 2008-06-28 20:19:05 PDT
(In reply to comment #3) > Sam pointed out in the channel that you forgot to remove the declaration for > JSArray::inlineGetOwnPropertySlot, and that the getOwnPropertySlotSlowCase may > be a better name for getSlowCase. Definitely remove the declaration before > landing, but what do you think about his suggestion about the name change for > getSlowCase? The longer name seems OK. I'll make both changes.
Darin Adler
Comment 5 2008-06-28 22:24:10 PDT
http://trac.webkit.org/changeset/34867
Note You need to log in before you can comment on or make changes to this bug.