Bug 198031 – Add a mach-lookup for 'AGXCompilerService'

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Zhifei Fang]

<rdar://problem/50552974>

[Zhifei Fang]

Created attachment 370240 [details]
Patch

[Maciej Stachowiak]

Looks good to me but perhaps Brent or Per Arne should look at it as well.

[Per Arne Vollan]

Comment on attachment 370240 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370240&action=review

R=me.

> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:-402
>  (deny mach-lookup
> -    (global-name "com.apple.AGXCompilerService")

Do you need to explicitly allow it, or is it enough to remove it from the deny list?

[EWS]

Comment on attachment 370240 [details]
Patch

Rejecting attachment 370240 [details] from commit-queue.

[e-mail] does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Commit Bot]

Comment on attachment 370240 [details]
Patch

Clearing flags on attachment: 370240

Committed r245520: <https://trac.webkit.org/changeset/245520>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/50951531>