Bug 198031 - Add a mach-lookup for 'AGXCompilerService'
Summary: Add a mach-lookup for 'AGXCompilerService'
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-19 23:11 PDT by Zhifei Fang
Modified: 2019-05-20 10:43 PDT (History)
9 users (show)

See Also:


Attachments
Patch (1.54 KB, patch)
2019-05-19 23:20 PDT, Zhifei Fang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zhifei Fang 2019-05-19 23:11:08 PDT
<rdar://problem/50552974>
Comment 1 Zhifei Fang 2019-05-19 23:20:42 PDT
Created attachment 370240 [details]
Patch
Comment 2 Maciej Stachowiak 2019-05-20 02:03:13 PDT
Looks good to me but perhaps Brent or Per Arne should look at it as well.
Comment 3 Per Arne Vollan 2019-05-20 07:12:00 PDT
Comment on attachment 370240 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370240&action=review

R=me.

> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:-402
>  (deny mach-lookup
> -    (global-name "com.apple.AGXCompilerService")

Do you need to explicitly allow it, or is it enough to remove it from the deny list?
Comment 4 EWS 2019-05-20 10:34:56 PDT
Comment on attachment 370240 [details]
Patch

Rejecting attachment 370240 [details] from commit-queue.

zhifei_fang@apple.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 5 WebKit Commit Bot 2019-05-20 10:41:21 PDT
Comment on attachment 370240 [details]
Patch

Clearing flags on attachment: 370240

Committed r245520: <https://trac.webkit.org/changeset/245520>
Comment 6 WebKit Commit Bot 2019-05-20 10:41:23 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-05-20 10:43:01 PDT
<rdar://problem/50951531>