Bug 198004 - Web Inspector: Storage tab crashes easily when adding new local/session storage entries.
Summary: Web Inspector: Storage tab crashes easily when adding new local/session stora...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 198003
Blocks:
  Show dependency tree / graph
 
Reported: 2019-05-17 15:01 PDT by Ross Kirsling
Modified: 2019-05-20 13:46 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.74 KB, patch)
2019-05-20 13:05 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2019-05-17 15:01:20 PDT 
(Evidently somebody noticed this a year ago on our end but it never got reported upstream... :sad_panda:)

Steps:
1. Open Storage tab
2. Double-click an empty row
3. Enter text for key
4. Press tab
5. Enter text for value
6. Press tab

Result:
> TypeError:​ undefined is not an object (evaluating 'this._editingNode._element.children')​ (at DataGrid.js:​523:​49)​
>     _startEditingNodeAtColumnIndex @ DataGrid.js:​523:​49
>     moveToNextCell @ DataGrid.js:​596:​52
>     _editingCommitted @ DataGrid.js:​606:​28
>     _editingCommitted @ [native code]​
>     editingCommitted @ EditingSupport.js:​197:​26
>     blurEventListener @ EditingSupport.js:​143:​30

Notes:
- After step 4, the text for the key disappears.
- If you press enter instead of tab in step 6, the crash does not occur and the text for the key re-appears, but now the text for the value disappears.
Comment 1 Devin Rousso 2019-05-20 13:05:14 PDT 
Created attachment 370268 [details]
Patch
Comment 2 Ross Kirsling 2019-05-20 13:18:56 PDT 
Comment on attachment 370268 [details]
Patch

Woohoo! r=me
Comment 3 WebKit Commit Bot 2019-05-20 13:45:28 PDT 
Comment on attachment 370268 [details]
Patch

Clearing flags on attachment: 370268

Committed r245535: <https://trac.webkit.org/changeset/245535>
Comment 4 WebKit Commit Bot 2019-05-20 13:45:29 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-05-20 13:46:19 PDT 
<rdar://problem/50958823>