Bug 197996 – [ews-build] Add clickable url in UI for uploaded S3 archive

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

We started uploading archives to S3 since https://bugs.webkit.org/show_bug.cgi?id=197922. It would be nice to have a clickable link in the UI for the archive URL.

[Aakash Jain]

Created attachment 370148 [details]
Patch

[Aakash Jain]

Sample run: https://ews-build.webkit-uat.org/#/builders/39/builds/542

[EWS Watchlist]

Attachment 370148 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:793:  [TransferToS3.start] Use of super on an old style class  [pylint/E1002] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jonathan Bedard]

Comment on attachment 370148 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370148&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:800
> +        match = re.search(r'S3 URL: (?P<url>[^\s]+)', log_text)

Can we have a comment here with an example of the line we're mapping?

[Aakash Jain]

Created attachment 370153 [details]
Patch

[Aakash Jain]

> Can we have a comment here with an example of the line we're mapping?
Added

[EWS Watchlist]

Attachment 370153 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:793:  [TransferToS3.start] Use of super on an old style class  [pylint/E1002] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 370153 [details]
Patch

Clearing flags on attachment: 370153

Committed r245489: <https://trac.webkit.org/changeset/245489>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/50910773>