Bug 197996 - [ews-build] Add clickable url in UI for uploaded S3 archive
Summary: [ews-build] Add clickable url in UI for uploaded S3 archive
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-17 13:27 PDT by Aakash Jain
Modified: 2019-05-17 16:47 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.51 KB, patch)
2019-05-17 14:01 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff
Patch (1.64 KB, patch)
2019-05-17 14:34 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-05-17 13:27:39 PDT
We started uploading archives to S3 since https://bugs.webkit.org/show_bug.cgi?id=197922. It would be nice to have a clickable link in the UI for the archive URL.
Comment 1 Aakash Jain 2019-05-17 14:01:29 PDT
Created attachment 370148 [details]
Patch
Comment 2 Aakash Jain 2019-05-17 14:03:01 PDT
Sample run: https://ews-build.webkit-uat.org/#/builders/39/builds/542
Comment 3 Build Bot 2019-05-17 14:04:32 PDT Comment hidden (obsolete)
Comment 4 Jonathan Bedard 2019-05-17 14:12:06 PDT
Comment on attachment 370148 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370148&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:800
> +        match = re.search(r'S3 URL: (?P<url>[^\s]+)', log_text)

Can we have a comment here with an example of the line we're mapping?
Comment 5 Aakash Jain 2019-05-17 14:34:28 PDT
Created attachment 370153 [details]
Patch
Comment 6 Aakash Jain 2019-05-17 14:35:35 PDT
> Can we have a comment here with an example of the line we're mapping?
Added
Comment 7 Build Bot 2019-05-17 14:37:36 PDT Comment hidden (obsolete)
Comment 8 WebKit Commit Bot 2019-05-17 16:45:44 PDT
Comment on attachment 370153 [details]
Patch

Clearing flags on attachment: 370153

Committed r245489: <https://trac.webkit.org/changeset/245489>
Comment 9 WebKit Commit Bot 2019-05-17 16:45:46 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2019-05-17 16:47:04 PDT
<rdar://problem/50910773>