Bug 197995 - Avoid races in taking networking assertions for downloads by having both Networking and UIProcess do it
Summary: Avoid races in taking networking assertions for downloads by having both Netw...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-17 13:08 PDT by Brady Eidson
Modified: 2019-05-17 14:37 PDT (History)
3 users (show)

See Also:


Attachments
Patch (8.11 KB, patch)
2019-05-17 13:12 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch (8.05 KB, patch)
2019-05-17 13:26 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch (8.09 KB, patch)
2019-05-17 13:50 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2019-05-17 13:08:51 PDT
Avoid races in taking networking assertions for downloads by having both Networking and UIProcess do it

<rdar://problem/50564630>
Comment 1 Brady Eidson 2019-05-17 13:12:31 PDT
Created attachment 370138 [details]
Patch
Comment 2 Brady Eidson 2019-05-17 13:26:01 PDT
Created attachment 370140 [details]
Patch
Comment 3 Chris Dumez 2019-05-17 13:40:09 PDT
Comment on attachment 370140 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370140&action=review

> Source/WebKit/NetworkProcess/Downloads/DownloadMap.cpp:64
> +        RELEASE_LOG(Loading, "Took 'WebKit downloads' assertion in NetworkProcess");

We normally use ProcessSuspension channel for such logging.

> Source/WebKit/NetworkProcess/Downloads/DownloadMap.cpp:78
> +        RELEASE_LOG(Loading, "Dropped 'WebKit downloads' assertion in NetworkProcess");

We normally use ProcessSuspension channel for such logging.

> Source/WebKit/UIProcess/Downloads/DownloadProxyMap.cpp:97
> +        RELEASE_LOG(Loading, "UIProcess took 'WebKit downloads' assertions for UIProcess and NetworkProcess");

We normally use ProcessSuspension channel for such logging.

> Source/WebKit/UIProcess/Downloads/DownloadProxyMap.cpp:125
> +        RELEASE_LOG(Loading, "UIProcess released 'WebKit downloads' assertions for UIProcess and NetworkProcess");

We normally use ProcessSuspension channel for such logging.

> Source/WebKit/UIProcess/Downloads/DownloadProxyMap.cpp:141
> +    RELEASE_LOG(Loading, "UIProcess DownloadProxyMap invalidated - Released 'WebKit downloads' assertions for UIProcess and NetworkProcess");

We normally use ProcessSuspension channel for such logging.
Comment 4 Brady Eidson 2019-05-17 13:50:13 PDT
Created attachment 370146 [details]
Patch
Comment 5 WebKit Commit Bot 2019-05-17 14:37:13 PDT
Comment on attachment 370146 [details]
Patch

Clearing flags on attachment: 370146

Committed r245480: <https://trac.webkit.org/changeset/245480>
Comment 6 WebKit Commit Bot 2019-05-17 14:37:15 PDT
All reviewed patches have been landed.  Closing bug.