Bug 19798 - REGRESSION: Masks have several problems in trunk
Summary: REGRESSION: Masks have several problems in trunk
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks: 19799
  Show dependency treegraph
 
Reported: 2008-06-28 03:32 PDT by Nikolas Zimmermann
Modified: 2008-08-12 14:11 PDT (History)
3 users (show)

See Also:


Attachments
Initial patch (7.31 KB, patch)
2008-08-12 03:41 PDT, Nikolas Zimmermann
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2008-06-28 03:32:18 PDT
All problems covered by existing LayoutTests. Unfortunately, when pixel tests aren't looked at, there is no way anyone could notice :(

svg/W3C-SVG-1.1/masking-mask-01-b.svg - masks seem translated
svg/custom/mask-inside-defs.svg - broken
svg/custom/visibility-override-mask.svg - broken
Comment 1 Nikolas Zimmermann 2008-08-11 21:24:41 PDT
Found the culprit: http://trac.webkit.org/changeset/31830/trunk/WebCore/svg/graphics/cg/SVGResourceMaskerCg.mm

Uploading fix soon.
Comment 2 Nikolas Zimmermann 2008-08-12 03:41:51 PDT
Created attachment 22744 [details]
Initial patch

Would be nice if David could have a look, as one of his refactorings broke SVG <mask> support.
Comment 3 Dave Hyatt 2008-08-12 13:57:48 PDT
Comment on attachment 22744 [details]
Initial patch

r=me
Comment 4 Nikolas Zimmermann 2008-08-12 14:11:47 PDT
Landed in r35694.