RESOLVED FIXED 197970
[css-text] break-spaces hangs a sequence of white spaces if it completely overflows the line length 
https://bugs.webkit.org/show_bug.cgi?id=197970
Summary [css-text] break-spaces hangs a sequence of white spaces if it completely ove...
Javier Fernandez
Reported 2019-05-16 16:26:28 PDT
Created attachment 370085 [details] Test case to reproduce the issue What steps will reproduce the problem? (1) Load the attached test case What is the expected result? The line is broken after the first space after the word ("XXXX | XX"), assuming such space overflows the line; the rest of the white space sequence should me moved to the next line (expected.png) What happens instead? The line is broken after the last white space character, letting the whole sequence to overflow ("XXXX |XX"); the next word is moved to the beginning of the next line (actual.png)
Attachments
Test case to reproduce the issue (164 bytes, text/html)
2019-05-16 16:26 PDT, Javier Fernandez 		no flags
Details
Actual result (493 bytes, image/png)
2019-05-16 16:29 PDT, Javier Fernandez 		no flags
Details
Expected result (448 bytes, image/png)
2019-05-16 16:29 PDT, Javier Fernandez 		no flags
Details
Patch (8.03 KB, patch)
2019-06-05 09:01 PDT, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Patch (8.67 KB, patch)
2019-06-06 02:14 PDT, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Patch (8.49 KB, patch)
2019-06-06 02:18 PDT, Javier Fernandez 		ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews105 for mac-highsierra-wk2 (3.09 MB, application/zip)
2019-06-06 03:33 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Javier Fernandez
Comment 1 2019-05-16 16:29:08 PDT
Created attachment 370086 [details] Actual result
Javier Fernandez
Comment 2 2019-05-16 16:29:26 PDT
Created attachment 370087 [details] Expected result
Javier Fernandez
Comment 3 2019-05-16 16:30:38 PDT
This bug only happens when executing the SimpleLineLayout codepath, so WebKitGtk+ and WPE are not affected y this bug.
Javier Fernandez
Comment 4 2019-05-16 16:32:03 PDT
I noticed that forcing a relayout (by selecting some text and running the web inspector) produces a line breaking like the one described in the expected results (expected.png).
Javier Fernandez
Comment 5 2019-06-05 09:01:02 PDT
Created attachment 371403 [details] Patch
Javier Fernandez
Comment 6 2019-06-06 02:14:49 PDT
Created attachment 371480 [details] Patch Some refactoring
Javier Fernandez
Comment 7 2019-06-06 02:18:25 PDT
Created attachment 371481 [details] Patch Rephrase comments
EWS Watchlist
Comment 8 2019-06-06 03:33:15 PDT
Comment on attachment 371481 [details] Patch Attachment 371481 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12393764 New failing tests: http/wpt/service-workers/service-worker-networkprocess-crash.html
EWS Watchlist
Comment 9 2019-06-06 03:33:17 PDT
Created attachment 371484 [details] Archive of layout-test-results from ews105 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Diego Pino
Comment 10 2020-03-12 03:29:38 PDT
Fixed by r257562.
alan
Comment 11 2020-03-15 08:17:44 PDT
(In reply to Diego Pino from comment #10) > Fixed by r257562. Yay. IFC FTW!
alan
Comment 12 2020-03-15 08:18:52 PDT
I guess this patch should be marked obsolete.
Note You need to log in before you can comment on or make changes to this bug.