Bug 197961 - [PlayStation] Don't call fcntl.
Summary: [PlayStation] Don't call fcntl.
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
Keywords: InRadar
Depends on:
Reported: 2019-05-16 13:38 PDT by Ross Kirsling
Modified: 2019-05-21 17:55 PDT (History)
7 users (show)

See Also:

Patch (2.73 KB, patch)
2019-05-16 13:39 PDT, Ross Kirsling
no flags Details | Formatted Diff | Diff
Patch (15.19 KB, patch)
2019-05-21 16:55 PDT, Ross Kirsling
no flags Details | Formatted Diff | Diff
Patch (15.20 KB, patch)
2019-05-21 17:04 PDT, Ross Kirsling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2019-05-16 13:38:14 PDT
[PlayStation] Don't call fcntl.
Comment 1 Ross Kirsling 2019-05-16 13:39:30 PDT
Created attachment 370062 [details]
Comment 2 Ross Kirsling 2019-05-16 13:40:50 PDT
Simple patch, but we need to come up with a better #if to use before landing.
Comment 3 Stephan Szabo 2019-05-20 08:21:01 PDT
We probably should also be protecting the #ifdef F_DUPFD_CLOEXEC case in dupCloseOnExec since we could get the define while still not being allowed to call fcntl.
Comment 4 Ross Kirsling 2019-05-21 16:55:53 PDT Comment hidden (obsolete)
Comment 5 EWS Watchlist 2019-05-21 16:57:11 PDT Comment hidden (obsolete)
Comment 6 Ross Kirsling 2019-05-21 17:04:37 PDT
Created attachment 370358 [details]
Comment 7 EWS Watchlist 2019-05-21 17:06:12 PDT
Attachment 370358 [details] did not pass style-queue:

ERROR: Source/WTF/wtf/unix/UniStdExtrasUnix.cpp:28:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WTF/wtf/playstation/UniStdExtrasPlayStation.cpp:28:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 12 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 WebKit Commit Bot 2019-05-21 17:54:46 PDT
Comment on attachment 370358 [details]

Clearing flags on attachment: 370358

Committed r245606: <https://trac.webkit.org/changeset/245606>
Comment 9 WebKit Commit Bot 2019-05-21 17:54:47 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2019-05-21 17:55:28 PDT