Bug 197959 - Allow sequential playback of media files when initial playback started with a user gesture
Summary: Allow sequential playback of media files when initial playback started with a...
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-16 13:20 PDT by Eric Carlson
Modified: 2019-05-17 09:39 PDT (History)
5 users (show)

See Also:


Attachments
Patch (16.67 KB, patch)
2019-05-16 13:30 PDT, Eric Carlson
youennf: review+
ews: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-highsierra (3.08 MB, application/zip)
2019-05-16 14:43 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews107 for mac-highsierra-wk2 (2.66 MB, application/zip)
2019-05-16 14:57 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews113 for mac-highsierra (2.88 MB, application/zip)
2019-05-16 15:22 PDT, Build Bot
no flags Details
Patch (20.92 KB, patch)
2019-05-17 06:48 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2019-05-16 13:20:24 PDT
Allow sequential playback of media files when initial playback started with a user gesture
Comment 1 Eric Carlson 2019-05-16 13:28:36 PDT
<rdar://problem/50655207>
Comment 2 Eric Carlson 2019-05-16 13:30:24 PDT
Created attachment 370061 [details]
Patch
Comment 3 youenn fablet 2019-05-16 14:29:42 PDT
Comment on attachment 370061 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370061&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:5921
> +        document().mediaFinishedPlaying();

Maybe we should have a better name for mediaFinishedPlaying, since it is not called for every media but only 'unrestricted' media.
Comment 4 Build Bot 2019-05-16 14:43:07 PDT
Comment on attachment 370061 [details]
Patch

Attachment 370061 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/12209476

New failing tests:
media/media-fullscreen-inline.html
Comment 5 Build Bot 2019-05-16 14:43:08 PDT
Created attachment 370072 [details]
Archive of layout-test-results from ews101 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 6 Build Bot 2019-05-16 14:57:17 PDT
Comment on attachment 370061 [details]
Patch

Attachment 370061 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12209555

New failing tests:
media/media-fullscreen-inline.html
Comment 7 Build Bot 2019-05-16 14:57:19 PDT
Created attachment 370074 [details]
Archive of layout-test-results from ews107 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 8 Build Bot 2019-05-16 15:22:10 PDT
Comment on attachment 370061 [details]
Patch

Attachment 370061 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12209593

New failing tests:
media/media-fullscreen-inline.html
Comment 9 Build Bot 2019-05-16 15:22:11 PDT
Created attachment 370075 [details]
Archive of layout-test-results from ews113 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 10 Eric Carlson 2019-05-17 06:10:55 PDT
Comment on attachment 370061 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370061&action=review

>> Source/WebCore/html/HTMLMediaElement.cpp:5921
>> +        document().mediaFinishedPlaying();
> 
> Maybe we should have a better name for mediaFinishedPlaying, since it is not called for every media but only 'unrestricted' media.

Good point, I'll change the name to userActivatedMediaFinishedPlaying.
Comment 11 Eric Carlson 2019-05-17 06:48:41 PDT
Created attachment 370114 [details]
Patch
Comment 12 WebKit Commit Bot 2019-05-17 09:39:15 PDT
Comment on attachment 370114 [details]
Patch

Clearing flags on attachment: 370114

Committed r245467: <https://trac.webkit.org/changeset/245467>