Bug 197953 - CoreAudioCaptureSource should be marked as an audio capture track
Summary: CoreAudioCaptureSource should be marked as an audio capture track
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-16 11:41 PDT by youenn fablet
Modified: 2019-05-16 14:50 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.43 KB, patch)
2019-05-16 11:44 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (1.43 KB, patch)
2019-05-16 12:21 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-05-16 11:41:25 PDT 
CoreAudioCaptureSource should be marked as an audio capture track
Comment 1 youenn fablet 2019-05-16 11:41:47 PDT 
<rdar://problem/50552007>
Comment 2 youenn fablet 2019-05-16 11:44:41 PDT 
Created attachment 370051 [details]
Patch
Comment 3 Eric Carlson 2019-05-16 12:09:31 PDT 
Comment on attachment 370051 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370051&action=review

> Source/WebCore/ChangeLog:12
> +        Matk it as microphone so that it can get muted properly.

s/Matk/Mark/
Comment 4 youenn fablet 2019-05-16 12:21:24 PDT 
Created attachment 370054 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-05-16 14:50:11 PDT 
Comment on attachment 370054 [details]
Patch for landing

Clearing flags on attachment: 370054

Committed r245407: <https://trac.webkit.org/changeset/245407>
Comment 6 WebKit Commit Bot 2019-05-16 14:50:13 PDT 
All reviewed patches have been landed.  Closing bug.