Bug 197943 - Add a website policy to disable the legacy -webkit-overflow-scrolling:touch behavior
Summary: Add a website policy to disable the legacy -webkit-overflow-scrolling:touch b...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-16 02:25 PDT by Antoine Quint
Modified: 2019-05-17 15:05 PDT (History)
6 users (show)

See Also:


Attachments
Patch (18.45 KB, patch)
2019-05-16 02:30 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (25.64 KB, patch)
2019-05-17 01:32 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (8.06 MB, application/zip)
2019-05-17 03:31 PDT, Build Bot
no flags Details
Patch (26.67 KB, patch)
2019-05-17 12:15 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (26.58 KB, patch)
2019-05-17 12:23 PDT, Antoine Quint
bfulgham: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2019-05-16 02:25:46 PDT
Add a website policy to disable the legacy -webkit-overflow-scrolling:touch behavior
Comment 1 Antoine Quint 2019-05-16 02:26:12 PDT
<rdar://problem/49078202>
Comment 2 Antoine Quint 2019-05-16 02:30:48 PDT
Created attachment 370033 [details]
Patch
Comment 3 Antoine Quint 2019-05-16 10:29:17 PDT
Wenson says this can be tested with <!-- webkit-test-runner [ shouldUseModernCompatibilityMode=true ] -->.
Comment 4 Antoine Quint 2019-05-16 10:29:48 PDT
Simon, do you know which tests should be duplicated to also test them with the legacy mode disabled?
Comment 5 Simon Fraser (smfr) 2019-05-16 11:06:51 PDT
I think you want variants of:
platform/ios/ios/fast/css/webkit-overflow-scrolling-parsing.html
fast/scrolling/ios/overflow-scrolling-touch-enabled-stacking.html
Comment 6 Antoine Quint 2019-05-17 01:32:42 PDT
Created attachment 370110 [details]
Patch
Comment 7 Build Bot 2019-05-17 03:31:48 PDT
Comment on attachment 370110 [details]
Patch

Attachment 370110 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12213804

New failing tests:
platform/ipad/fast/css/webkit-overflow-scrolling-parsing-modern-compatibility-mode.html
fast/scrolling/ipad/overflow-scrolling-touch-enabled-stacking-modern-compatibility-mode.html
Comment 8 Build Bot 2019-05-17 03:31:50 PDT
Created attachment 370113 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.5
Comment 9 Brent Fulgham 2019-05-17 09:44:03 PDT
Comment on attachment 370110 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370110&action=review

> Source/WebCore/ChangeLog:10
> +               platform/ipad/fast/css/webkit-overflow-scrolling-parsing-modern-compatibility-mode.html

These tests don't seem to work on iOS-simulator, which is the only place we run iOS tests (atm). That makes it seem like this patch doesn't work.

Or do our build.webkit.org tests only run without "#if ENABLE(OVERFLOW_SCROLLING_TOUCH)" disabled?
Comment 10 Wenson Hsieh 2019-05-17 09:50:43 PDT
Comment on attachment 370110 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370110&action=review

>> Source/WebCore/ChangeLog:10
>> +               platform/ipad/fast/css/webkit-overflow-scrolling-parsing-modern-compatibility-mode.html
> 
> These tests don't seem to work on iOS-simulator, which is the only place we run iOS tests (atm). That makes it seem like this patch doesn't work.
> 
> Or do our build.webkit.org tests only run without "#if ENABLE(OVERFLOW_SCROLLING_TOUCH)" disabled?

The implementation of "modern compatibility mode" is tucked away in WebKitAdditions. It's not expected that these tests will work with just open source code.
Comment 11 Antoine Quint 2019-05-17 12:15:09 PDT
Created attachment 370132 [details]
Patch
Comment 12 Antoine Quint 2019-05-17 12:23:28 PDT
Created attachment 370133 [details]
Patch
Comment 13 Brent Fulgham 2019-05-17 12:30:21 PDT
Comment on attachment 370133 [details]
Patch

r=mews
Comment 14 Antoine Quint 2019-05-17 15:05:17 PDT
Committed r245483: <https://trac.webkit.org/changeset/245483>