Bug 197943 – Add a website policy to disable the legacy -webkit-overflow-scrolling:touch behavior

• Status: RESOLVED
• Resolution: FIXED
• Component: Scrolling

[Antoine Quint]

Add a website policy to disable the legacy -webkit-overflow-scrolling:touch behavior

[Antoine Quint]

<rdar://problem/49078202>

[Antoine Quint]

Created attachment 370033 [details]
Patch

[Antoine Quint]

Wenson says this can be tested with <!-- webkit-test-runner [ shouldUseModernCompatibilityMode=true ] -->.

[Antoine Quint]

Simon, do you know which tests should be duplicated to also test them with the legacy mode disabled?

[Simon Fraser (smfr)]

I think you want variants of:
platform/ios/ios/fast/css/webkit-overflow-scrolling-parsing.html
fast/scrolling/ios/overflow-scrolling-touch-enabled-stacking.html

[Antoine Quint]

Created attachment 370110 [details]
Patch

[EWS Watchlist]

Comment on attachment 370110 [details]
Patch

Attachment 370110 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12213804

New failing tests:
platform/ipad/fast/css/webkit-overflow-scrolling-parsing-modern-compatibility-mode.html
fast/scrolling/ipad/overflow-scrolling-touch-enabled-stacking-modern-compatibility-mode.html

[EWS Watchlist]

Created attachment 370113 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.5

[Brent Fulgham]

Comment on attachment 370110 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370110&action=review

> Source/WebCore/ChangeLog:10
> +               platform/ipad/fast/css/webkit-overflow-scrolling-parsing-modern-compatibility-mode.html

These tests don't seem to work on iOS-simulator, which is the only place we run iOS tests (atm). That makes it seem like this patch doesn't work.

Or do our build.webkit.org tests only run without "#if ENABLE(OVERFLOW_SCROLLING_TOUCH)" disabled?

[Wenson Hsieh]

Comment on attachment 370110 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370110&action=review

>> Source/WebCore/ChangeLog:10
>> +               platform/ipad/fast/css/webkit-overflow-scrolling-parsing-modern-compatibility-mode.html
> 
> These tests don't seem to work on iOS-simulator, which is the only place we run iOS tests (atm). That makes it seem like this patch doesn't work.
> 
> Or do our build.webkit.org tests only run without "#if ENABLE(OVERFLOW_SCROLLING_TOUCH)" disabled?

The implementation of "modern compatibility mode" is tucked away in WebKitAdditions. It's not expected that these tests will work with just open source code.

[Antoine Quint]

Created attachment 370132 [details]
Patch

[Antoine Quint]

Created attachment 370133 [details]
Patch

[Brent Fulgham]

Comment on attachment 370133 [details]
Patch

r=mews

[Antoine Quint]

Committed r245483: <https://trac.webkit.org/changeset/245483>