Bug 197942 - Horizontal scrollbar flashes after scrolling vertically with keyboard
Summary: Horizontal scrollbar flashes after scrolling vertically with keyboard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-16 01:17 PDT by Tim Horton
Modified: 2019-05-28 16:57 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.48 KB, patch)
2019-05-16 01:18 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews211 for win-future (13.62 MB, application/zip)
2019-05-16 05:18 PDT, EWS Watchlist 		no flags Details
Patch (3.89 KB, patch)
2019-05-16 18:25 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (3.90 KB, patch)
2019-05-28 16:20 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2019-05-16 01:17:36 PDT 
Horizontal scrollbar flashes after scrolling vertically with keyboard
Comment 1 Tim Horton 2019-05-16 01:18:47 PDT 
Created attachment 370029 [details]
Patch
Comment 2 Tim Horton 2019-05-16 01:19:13 PDT 
<rdar://problem/46169578>
Comment 3 EWS Watchlist 2019-05-16 05:18:12 PDT 
Comment on attachment 370029 [details]
Patch

Attachment 370029 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12205879

New failing tests:
fast/shadow-dom/svg-text-path-href-change-in-shadow-tree.html
js/dom/try-catch-crash.html
svg/text/textpath-reference-update.html
fast/shadow-dom/svg-use-href-change-in-shadow-tree.html
js/dom/custom-constructors.html
Comment 4 EWS Watchlist 2019-05-16 05:18:18 PDT 
Created attachment 370038 [details]
Archive of layout-test-results from ews211 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 5 Tim Horton 2019-05-16 18:25:53 PDT 
Created attachment 370098 [details]
Patch
Comment 6 Brent Fulgham 2019-05-28 14:27:57 PDT 
iOS Build failure:
WKKeyboardScrollingAnimator.mm:592:15: error: unused function 'axesForDelta' [-Werror,-Wunused-function]
Comment 7 Brent Fulgham 2019-05-28 14:29:07 PDT 
Comment on attachment 370098 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370098&action=review

> Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm:-592
> -- (void)scrollToContentOffset:(WebCore::FloatPoint)contentOffsetDelta animated:(BOOL)animated

#if HAVE(UI_SCROLL_VIEW_INDICATOR_FLASHING_SPI) ?
Comment 8 Tim Horton 2019-05-28 16:20:01 PDT 
Created attachment 370800 [details]
Patch
Comment 9 Dean Jackson 2019-05-28 16:22:39 PDT 
Comment on attachment 370800 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370800&action=review

> Source/WebKit/Platform/spi/ios/UIKitSPI.h:354
> +- (void)_flashScrollIndicatorsForAxes:(UIAxis)axes persistingPreviousFlashes:(BOOL)persisting;

Wow. https://www.quora.com/What-is-the-plural-form-of-axis-1
Comment 10 WebKit Commit Bot 2019-05-28 16:57:33 PDT 
Comment on attachment 370800 [details]
Patch

Clearing flags on attachment: 370800

Committed r245832: <https://trac.webkit.org/changeset/245832>
Comment 11 WebKit Commit Bot 2019-05-28 16:57:35 PDT 
All reviewed patches have been landed.  Closing bug.