Bug 197930 - REGRESSION (r245072): Missing code in Document::styleColorOptions to propagate StyleColor::Options::UseInactiveAppearance
Summary: REGRESSION (r245072): Missing code in Document::styleColorOptions to propagat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-15 15:47 PDT by Timothy Hatcher
Modified: 2019-05-15 16:50 PDT (History)
11 users (show)

See Also:


Attachments
Patch (2.65 KB, patch)
2019-05-15 15:55 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff
Patch (3.22 KB, patch)
2019-05-15 16:09 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2019-05-15 15:47:33 PDT
Some code was missed in my initial patch (r245072) that didn't propagate StyleColor::Options::UseInactiveAppearance from the Page.

<rdar://problem/49833954>
Comment 1 Timothy Hatcher 2019-05-15 15:55:41 PDT Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2019-05-15 15:58:37 PDT
Comment on attachment 370002 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370002&action=review

> Source/WebCore/dom/Document.cpp:6941
> +    if (Page* documentPage = page())

Nit - auto*
Comment 3 Megan Gardner 2019-05-15 16:02:04 PDT
Comment on attachment 370002 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370002&action=review

> Source/WebCore/dom/Document.cpp:6943
> +    return useInactiveAppearance;

Couldn't  this just be 
if (Page* documentPage = page())
 return documentPage->useInactiveAppearance();
return false;
Comment 4 Timothy Hatcher 2019-05-15 16:09:17 PDT
Created attachment 370006 [details]
Patch
Comment 5 WebKit Commit Bot 2019-05-15 16:50:40 PDT
Comment on attachment 370006 [details]
Patch

Clearing flags on attachment: 370006

Committed r245368: <https://trac.webkit.org/changeset/245368>
Comment 6 WebKit Commit Bot 2019-05-15 16:50:42 PDT
All reviewed patches have been landed.  Closing bug.