Bug 19791 – Inspector should show the source file that called console.time and console.timeEnd

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Web Inspector (Deprecated)

[Keishi Hattori]

The Inspector should show the source file that called console.time and console.timeEnd like Firebug.

[Keishi Hattori]

Created attachment 22704 [details]
as far as I have

[CustomCall] let's you override getCallData for a class like Console but I can't figure out how to override for a function like console.log.

Also, I can't figure out what callData.native.function points to. I think it eventually calls Console::log but I don't know what is in between.

[Timothy Hatcher]

I think Geoff or Oliver should review this. I am not sure adding a new type of CallData is right.

[Adam Roben (:aroben)]

(In reply to comment #2)
> I think Geoff or Oliver should review this.

I agree.

> I am not sure adding a new type of CallData is right.

That's what Geoff suggested in bug 17234.

[Timothy Hatcher]

I think using CustomCall for the Console object is fine. The majority of the console functions want this info.

Also the CallType name in JSCore should have a more generic name, since it could be used for other code.

[Timothy Hatcher]

Why do we have bug 17234 and this bug? Wouldn't we fix all of the console functions at once, not just tim/timeEnd?

[Keishi Hattori]

*** This bug has been marked as a duplicate of 17234 ***

[Timothy Hatcher]

Comment on attachment 22704 [details]
as far as I have

Clearing the review flag since this is a duplicate bug. Attach the patch to bug 17234.

[Kevin McCullough]

I talked with Geoff about how to get the line numbers and source files for more than just these functions.  I think we are going to be taking this in another direction.