Bug 197897 – Fix flakey test fast/events/autoscroll-when-input-is-offscreen.html

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Megan Gardner]

Fix flakey test fast/events/autoscroll-when-input-is-offscreen.html

[Megan Gardner]

Created attachment 369904 [details]
Patch

[Megan Gardner]

Created attachment 369905 [details]
Patch

[Megan Gardner]

<rdar://problem/50306931>

[Tim Horton]

Comment on attachment 369905 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369905&action=review

> LayoutTests/ChangeLog:9
> +        Espeically in debug, scrolling is slow enough that we need to allow for a

"Especially"

> LayoutTests/ChangeLog:10
> +        presentation update. Then we can be sure that the page has finished scrolling

"Scrolling is slow enough" isn't the right phrase. "Programmatic scrolls are included in the transaction and you want to ensure that they've been applied" is better.

> LayoutTests/fast/events/autoscroll-when-input-is-offscreen.html:22
>          var programaticScroll = 500;

Two "m"s in programmatic.

[Megan Gardner]

Created attachment 369908 [details]
Patch

[EWS Watchlist]

Comment on attachment 369908 [details]
Patch

Attachment 369908 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/12192748

New failing tests:
fast/events/autoscroll-when-input-is-offscreen.html

[EWS Watchlist]

Created attachment 369911 [details]
Archive of layout-test-results from ews100 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Megan Gardner]

Created attachment 369912 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 369912 [details]
Patch

Clearing flags on attachment: 369912

Committed r245316: <https://trac.webkit.org/changeset/245316>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

*** Bug 197379 has been marked as a duplicate of this bug. ***