Bug 197890 – [WHLSL] parseEffectfulAssignment should not call parseCallExpression directly

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGPU

[Robin Morisset]

callExpression already appears in effSuffix which is in effPrefix which is in effAssignment, so having it directly in effAssignment as well is useless (and ambiguous).
I've already fixed the grammar, this patch is fixing the parser.

[Robin Morisset]

Created attachment 369879 [details]
Patch

[Myles C. Maxfield]

I think we can test this patch. If the program fails to parse, the JS call should return null.

[Myles C. Maxfield]

Comment on attachment 369879 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369879&action=review

> Source/WebCore/ChangeLog:9
> +        I've already fixed the grammar, this patch is fixing the parser.

Let's link to the associated grammar fix and spec fix.

[Robin Morisset]

Created attachment 369882 [details]
Patch for landing

Added link in the changelog.

[WebKit Commit Bot]

Comment on attachment 369882 [details]
Patch for landing

Rejecting attachment 369882 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 369882, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=369882&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=197890&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 369882 from bug 197890.
Fetching: https://bugs.webkit.org/attachment.cgi?id=369882
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
patch: **** malformed patch at line 22:          Video frame resizing should be using Trim

patching file Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.cpp

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/12190332

[Robin Morisset]

Created attachment 369884 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 369884 [details]
Patch for landing

Clearing flags on attachment: 369884

Committed r245302: <https://trac.webkit.org/changeset/245302>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/50780514>