Bug 197890 - [WHLSL] parseEffectfulAssignment should not call parseCallExpression directly
Summary: [WHLSL] parseEffectfulAssignment should not call parseCallExpression directly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robin Morisset
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-14 12:04 PDT by Robin Morisset
Modified: 2019-05-14 13:36 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.52 KB, patch)
2019-05-14 12:08 PDT, Robin Morisset
mmaxfield: review+
Details | Formatted Diff | Diff
Patch for landing (1.66 KB, patch)
2019-05-14 12:35 PDT, Robin Morisset
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (1.63 KB, patch)
2019-05-14 12:55 PDT, Robin Morisset
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2019-05-14 12:04:33 PDT
callExpression already appears in effSuffix which is in effPrefix which is in effAssignment, so having it directly in effAssignment as well is useless (and ambiguous).
I've already fixed the grammar, this patch is fixing the parser.
Comment 1 Robin Morisset 2019-05-14 12:08:37 PDT
Created attachment 369879 [details]
Patch
Comment 2 Myles C. Maxfield 2019-05-14 12:16:23 PDT
I think we can test this patch. If the program fails to parse, the JS call should return null.
Comment 3 Myles C. Maxfield 2019-05-14 12:24:16 PDT
Comment on attachment 369879 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369879&action=review

> Source/WebCore/ChangeLog:9
> +        I've already fixed the grammar, this patch is fixing the parser.

Let's link to the associated grammar fix and spec fix.
Comment 4 Robin Morisset 2019-05-14 12:35:44 PDT
Created attachment 369882 [details]
Patch for landing

Added link in the changelog.
Comment 5 WebKit Commit Bot 2019-05-14 12:38:15 PDT
Comment on attachment 369882 [details]
Patch for landing

Rejecting attachment 369882 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 369882, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=369882&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=197890&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 369882 from bug 197890.
Fetching: https://bugs.webkit.org/attachment.cgi?id=369882
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
patch: **** malformed patch at line 22:          Video frame resizing should be using Trim

patching file Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.cpp

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/12190332
Comment 6 Robin Morisset 2019-05-14 12:55:30 PDT
Created attachment 369884 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2019-05-14 13:35:38 PDT
Comment on attachment 369884 [details]
Patch for landing

Clearing flags on attachment: 369884

Committed r245302: <https://trac.webkit.org/changeset/245302>
Comment 8 WebKit Commit Bot 2019-05-14 13:35:40 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-05-14 13:36:21 PDT
<rdar://problem/50780514>