Bug 197878 - <input type=color> should have box-sizing: border-box in UA stylesheet
Summary: <input type=color> should have box-sizing: border-box in UA stylesheet
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zsun
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-14 06:17 PDT by Simon Pieters (:zcorpan)
Modified: 2022-05-05 07:46 PDT (History)
15 users (show)

See Also:


Attachments
Patch (17.32 KB, patch)
2022-04-14 05:25 PDT, zsun
no flags Details | Formatted Diff | Diff
Patch (5.48 KB, patch)
2022-04-25 04:14 PDT, zsun
no flags Details | Formatted Diff | Diff
[fast-cq] Patch (20.35 KB, patch)
2022-05-04 02:04 PDT, zsun
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Pieters (:zcorpan) 2019-05-14 06:17:13 PDT
Spec issue: https://github.com/whatwg/html/issues/4281

Spec change: https://github.com/whatwg/html/pull/4143/files#diff-36cd38f49b9afa08222c0dc9ebfe35ebR112423

Test:
html/rendering/non-replaced-elements/form-controls/button-style.html
in
https://github.com/web-platform-tests/wpt/pull/14824
Comment 1 zsun 2022-04-14 05:25:11 PDT
Created attachment 457614 [details]
Patch
Comment 2 Aditya Keerthi 2022-04-14 15:43:48 PDT
Comment on attachment 457614 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457614&action=review

> Source/WebCore/rendering/RenderTheme.cpp:1235
> +    return "input[type=\"color\"] { appearance: auto; width: 50px; height: 27px; box-sizing: border-box; outline: none; } "_s;

How were the new width/height values determined?
Comment 3 zsun 2022-04-25 04:14:00 PDT
Created attachment 458258 [details]
Patch
Comment 4 Radar WebKit Bug Importer 2022-04-27 07:47:27 PDT
<rdar://problem/92396765>
Comment 5 Tim Nguyen (:ntim) 2022-05-03 09:47:01 PDT
Comment on attachment 458258 [details]
Patch

Looks like mac-wk1 needs a special baseline.

Can you add special test expectations for mac-wk1?

Looks like this is just because <input type=color> is disabled with WebKitLegacy: https://webkit-search.igalia.com/webkit/source/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml#425-437
Comment 6 zsun 2022-05-04 02:04:32 PDT
Created attachment 458780 [details]
[fast-cq] Patch
Comment 7 Tim Nguyen (:ntim) 2022-05-04 06:09:58 PDT
Comment on attachment 458780 [details]
[fast-cq] Patch

r=me
Comment 8 EWS 2022-05-05 07:46:18 PDT
Committed r293830 (250303@main): <https://commits.webkit.org/250303@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458780 [details].