Bug 19787 - create most arrays from values in registers rather than with multiple put operations
Summary: create most arrays from values in registers rather than with multiple put ope...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-26 23:44 PDT by Darin Adler
Modified: 2008-06-28 22:25 PDT (History)
0 users

See Also:


Attachments
patch (8.62 KB, patch)
2008-06-26 23:48 PDT, Darin Adler
no flags Details | Formatted Diff | Diff
patch (8.66 KB, patch)
2008-06-26 23:49 PDT, Darin Adler
no flags Details | Formatted Diff | Diff
patch, updated for TOT and revised based on Geoff's feedback (14.15 KB, patch)
2008-06-27 21:35 PDT, Darin Adler
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2008-06-26 23:44:33 PDT
This is a speed optimization.

It's a new opcode.
Comment 1 Darin Adler 2008-06-26 23:48:24 PDT
Created attachment 21968 [details]
patch
Comment 2 Darin Adler 2008-06-26 23:49:32 PDT
Created attachment 21969 [details]
patch

Forgot to include the SunSpider speed-up figure in the ChangeLog.
Comment 3 Darin Adler 2008-06-27 21:35:39 PDT
Created attachment 21981 [details]
patch, updated for TOT and revised based on Geoff's feedback
Comment 4 Oliver Hunt 2008-06-28 00:36:50 PDT
Comment on attachment 21981 [details]
patch, updated for TOT and revised based on Geoff's feedback

r=me, but the removal of the in place constructors should be a separate patch.  However, r=me on removing them as well :D
Comment 5 Cameron Zwarich (cpst) 2008-06-28 01:49:14 PDT
You should also probably update the op_new_array documentation.
Comment 6 Darin Adler 2008-06-28 22:25:37 PDT
http://trac.webkit.org/changeset/34851