RESOLVED FIXED 19787
create most arrays from values in registers rather than with multiple put operations
https://bugs.webkit.org/show_bug.cgi?id=19787
Summary create most arrays from values in registers rather than with multiple put ope...
Darin Adler
Reported 2008-06-26 23:44:33 PDT
This is a speed optimization. It's a new opcode.
Attachments
patch (8.62 KB, patch)
2008-06-26 23:48 PDT, Darin Adler
no flags
patch (8.66 KB, patch)
2008-06-26 23:49 PDT, Darin Adler
no flags
patch, updated for TOT and revised based on Geoff's feedback (14.15 KB, patch)
2008-06-27 21:35 PDT, Darin Adler
oliver: review+
Darin Adler
Comment 1 2008-06-26 23:48:24 PDT
Darin Adler
Comment 2 2008-06-26 23:49:32 PDT
Created attachment 21969 [details] patch Forgot to include the SunSpider speed-up figure in the ChangeLog.
Darin Adler
Comment 3 2008-06-27 21:35:39 PDT
Created attachment 21981 [details] patch, updated for TOT and revised based on Geoff's feedback
Oliver Hunt
Comment 4 2008-06-28 00:36:50 PDT
Comment on attachment 21981 [details] patch, updated for TOT and revised based on Geoff's feedback r=me, but the removal of the in place constructors should be a separate patch. However, r=me on removing them as well :D
Cameron Zwarich (cpst)
Comment 5 2008-06-28 01:49:14 PDT
You should also probably update the op_new_array documentation.
Darin Adler
Comment 6 2008-06-28 22:25:37 PDT
Note You need to log in before you can comment on or make changes to this bug.